Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for VPCs in dry-run mode #117

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

kirantejaj
Copy link
Contributor

@kirantejaj kirantejaj commented Jul 26, 2023

fix #116

@kirantejaj kirantejaj requested review from a team and imrannayer as code owners July 26, 2023 14:25
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer changed the title adding support for VPCs in dry-run mode feat: adding support for VPCs in dry-run mode Jul 26, 2023
@imrannayer imrannayer changed the title feat: adding support for VPCs in dry-run mode feat: Support for VPCs in dry-run mode Jul 26, 2023
@imrannayer
Copy link
Collaborator

@kirantejaj can you plz follow this doc. You are missing following steps:

make make generate_docs

You can test lint locally before pushing PR:

make docker_test_lint

@kirantejaj
Copy link
Contributor Author

@kirantejaj can you plz follow this doc. You are missing following steps:

make make generate_docs

You can test lint locally before pushing PR:

make docker_test_lint

@imrannayer Ran the suggested steps.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit 38eb822 into terraform-google-modules:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resources_dry_run doesn't have a condition to append //compute.googleapis.com to VPC IDs
2 participants