Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variables): fail gracefully if sources index does not exist #146

Conversation

eeaton
Copy link
Contributor

@eeaton eeaton commented May 24, 2024

add logic to fail gracefully if the map reference egress_policies.value["from"]["sources"] or ingress_policies.value["from"]["sources"] fails because the "sources" index does not exist. Both the from and sources blocks are optional in provider docs.

Issue identified in: terraform-google-modules/terraform-example-foundation#1251 (comment)

…ources"]` or `ingress_policies.value["from"]["sources] does not exist. Both the from and sources blocks are optional in provider docs.
@daniel-cit
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As this is to a module, we should prefix as fix so it triggers release-please and includes in the notes

@apeabody apeabody changed the title chore(variables): fail gracefully if sources index does not exist fix(variables): fail gracefully if sources index does not exist May 24, 2024
@apeabody apeabody merged commit 49973a3 into terraform-google-modules:master May 24, 2024
4 checks passed
@eeaton eeaton deleted the fix-egresspolicy-optional-source branch May 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants