Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VPC Accessible Services configuration #84

Conversation

masterleros
Copy link
Contributor

Adding missing configuration for VPC Accessible Services

@google-cla
Copy link

google-cla bot commented Mar 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@comment-bot-dev
Copy link

comment-bot-dev commented Mar 14, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @masterleros
Could you also sign the CLA

modules/regular_service_perimeter/variables.tf Outdated Show resolved Hide resolved
@masterleros
Copy link
Contributor Author

Thanks for the PR @masterleros Could you also sign the CLA

@bharathkkb CLA is already signed, all the changed are done, not sure why the build has failed, could you please retrigger it?
Thank you

@bharathkkb
Copy link
Member

/gcbrun

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit

modules/regular_service_perimeter/variables.tf Outdated Show resolved Hide resolved
modules/regular_service_perimeter/variables.tf Outdated Show resolved Hide resolved
masterleros and others added 3 commits March 16, 2022 15:22
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
@bharathkkb bharathkkb merged commit ccc56a8 into terraform-google-modules:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants