Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove cra ignore rule #64

Merged
merged 2 commits into from
Aug 18, 2023
Merged

ci: remove cra ignore rule #64

merged 2 commits into from
Aug 18, 2023

Conversation

ocofaigh
Copy link
Member

@ocofaigh ocofaigh commented Jul 31, 2023

Description

The rule should pass when CRA 1.3.11 is released, so will trigger the pipeline once this is out

Types of changes in this PR

Changes that affect the core Terraform module or submodules

  • Bug fix
  • New feature
  • Dependency update

Changes that don't affect the core Terraform module or submodules

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.

Your notes help the merger write the commit message for the PR that is published in the release notes for the module.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@ocofaigh
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh requested a review from Ak-sky August 17, 2023 16:28
@ocofaigh
Copy link
Member Author

1.3.11 is released and seems to be passing pipeline now

@ocofaigh ocofaigh merged commit 9248ad7 into main Aug 18, 2023
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch August 18, 2023 08:30
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants