Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add description value in ibm_iam_authorization… #91

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

Khuzaima05
Copy link
Member

Description

Pass description value to ibm_iam_authorization_policy block.

issue : https://github.ibm.com/GoldenEye/issues/issues/5662

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@Khuzaima05 Khuzaima05 self-assigned this Sep 7, 2023
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 requested a review from ocofaigh September 7, 2023 08:10
main.tf Outdated
@@ -92,6 +92,7 @@ resource "ibm_iam_authorization_policy" "kms_policy" {
target_service_name = local.kms_service
target_resource_instance_id = var.existing_kms_instance_guid
roles = ["Reader"]
description = "Allow all es instances in the resource group ${var.resource_group_id} to read from the ${local.kms_service} instance GUID ${var.existing_kms_instance_guid}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es -> Event Streams

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

@Khuzaima05
Copy link
Member Author

/run pipeline

main.tf Outdated Show resolved Hide resolved
@Khuzaima05
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 9ea80fb into main Sep 8, 2023
@ocofaigh ocofaigh deleted the add_description branch September 8, 2023 08:48
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants