feat: create service credentials, remove the CBR rule and set kms_encryption_enabled to true for fscloud module

[dishankkalra23]

Description

• This PR adds following:
  • support to create service credentials
  • remove the CBR rule in complete example to fix failures
  • set kms_encryption_enabled to true for fscloud module

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Issue: https://github.ibm.com/GoldenEye/issues/issues/10936

Release notes content

Adds support to create service credentials, set kms_encryption_enabled to true for fscloud module and fixes failing complete example

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[dishankkalra23]

Hey @akocbek, Can you please review this PR?

[dishankkalra23]

/run pipeline

[dishankkalra23]

TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: ╷
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ Error: ---
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ id: terraform-1296f030
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ summary: "resourceIBMEventStreamsTopicCreate createSaramaAdminClient: kafka: client
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   has run out of available brokers to talk to: 6 errors occurred:\n\t* kafka server:
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   SASL Authentication failed: Authentication failed, invalid credentials\n\t* kafka
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n"
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ severity: error
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ resource: ibm_event_streams_topic
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ operation: create
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ component:
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   name: github.com/IBM-Cloud/terraform-provider-ibm
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   version: 1.70.0
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ ---
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ 
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ 
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   with module.event_streams.ibm_event_streams_topic.es_topic[1],
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   on ../../main.tf line 73, in resource "ibm_event_streams_topic" "es_topic":
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │   73: resource "ibm_event_streams_topic" "es_topic" {
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: │ 
TestRunUpgradeExample 2024-10-16T05:31:18Z logger.go:66: ╵

Upgrade test is failing on master with this error, re-running the pipeline should resolve it

[dishankkalra23]

/run pipeline

[Ak-sky]

• Test is failing with below error as the request could not reach to private endpoint of ES instance due to the wrong CBR rule endpoint set here at

  terraform-ibm-event-streams/examples/complete/main.tf

  Line 72 in 1b64550

  "value" : "private"

  in complete example.

TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │ Error: ---
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │ id: terraform-1296f030
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │ summary: "resourceIBMEventStreamsTopicCreate createSaramaAdminClient: kafka: client
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │   has run out of available brokers to talk to: 6 errors occurred:\n\t* kafka server:
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │   SASL Authentication failed: Authentication failed, invalid credentials\n\t* kafka
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │   server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n"
TestRunUpgradeExample 2024-10-22T17:10:44Z logger.go:66: │ severity: error

• Have to skip upgrade test here to fix this.

[ocofaigh]

see comments

[ocofaigh]

Needs to also be exposed in fscloud submodule and the DA

[ocofaigh]

see https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/pull/312/files#r1816553508

[ocofaigh]

Would you be able to include the fix in #321 in this PR too please? The fscloud submodule is currently broken without that fix

[dishankkalra23]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

• GitHub release
• v2.5.0

Your semantic-release bot 📦🚀