Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing test #321

Closed
wants to merge 2 commits into from
Closed

fix: failing test #321

wants to merge 2 commits into from

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Oct 21, 2024

Description

https://github.ibm.com/GoldenEye/issues/issues/11171

fix failing test

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Oct 21, 2024
@jor2 jor2 requested review from Ak-sky and akocbek as code owners October 21, 2024 21:59
@jor2
Copy link
Member Author

jor2 commented Oct 21, 2024

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@jor2 jor2 requested a review from ocofaigh October 22, 2024 15:32
@jor2
Copy link
Member Author

jor2 commented Oct 22, 2024

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Oct 22, 2024

/run pipeline

@kccox kccox mentioned this pull request Oct 23, 2024
6 tasks
@jor2
Copy link
Member Author

jor2 commented Oct 24, 2024

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Oct 24, 2024

/run pipeline

@ocofaigh
Copy link
Member

I have asked @dishankkalra23 to include this fix in #312 since his PR is fixing the issue thats failing the tests currently

@ocofaigh
Copy link
Member

Fixed in #312

@ocofaigh ocofaigh closed this Oct 25, 2024
@ocofaigh ocofaigh deleted the fix-test branch October 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants