Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get kafka_brokers_sasl from instance.extensions #323

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

JunliWang
Copy link
Contributor

@JunliWang JunliWang commented Oct 24, 2024

Description

request from customer

 
It is a terraform feature request.
 
So we need to get bootstrap cluster when cluster deployment is terminated.
 
To get bootstrap cluster (variable kafka_brokers_sasl) we must create a first topic. If we don’t create a topic on cluster.. kafka_brokers_sasl variable is empty.
 
So we would like to be able to get variable kafka_brokers_sasl without having to create a first topic.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@JunliWang
Copy link
Contributor Author

/run pipeline

Copy link

@JunliWang you must be in the team github-collaborators in order to trigger the pipeline.

@Ak-sky
Copy link
Member

Ak-sky commented Oct 24, 2024

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Oct 25, 2024

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Oct 25, 2024

PR pipeline failing with below error, waiting on this fix to get merged.

TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │ summary: "resourceIBMEventStreamsTopicCreate createSaramaAdminClient: kafka: client
TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │   has run out of available brokers to talk to: 6 errors occurred:\n\t* kafka server:
TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │   SASL Authentication failed: Authentication failed, invalid credentials\n\t* kafka
TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │   server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n\t*
TestRunUpgradeExample 2024-10-25T06:12:53Z logger.go:66: │   kafka server: SASL Authentication failed: Authentication failed, invalid credentials\n"

.gitignore Show resolved Hide resolved
@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit 246727d into terraform-ibm-modules:main Oct 25, 2024
2 checks passed
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants