Add schema global compatibility rule #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional review notes:
|
kccox
force-pushed
the
add-schema-global-rule
branch
from
415d358 to
bb4e622
Compare
|
/run pipeline |
Ak-sky
reviewed
Nov 19, 2024
ocofaigh
reviewed
Nov 19, 2024
variables.tf
Outdated
| variable "schema_global_rule" { | ||
| type = string | ||
| description = "Schema global compatibility rule. Only allowed for enterprise plan, must be '' for other plans. Allowed values are 'NONE', 'FULL', 'FULL_TRANSITIVE', 'FORWARD', 'FORWARD_TRANSITIVE', 'BACKWARD', 'BACKWARD_TRANSITIVE'." | ||
| default = "" |
There was a problem hiding this comment.
its better practise to default to null instead of empty string
ocofaigh
reviewed
Nov 19, 2024
main.tf
Outdated
| @@ -26,6 +26,8 @@ locals { | |||
| ) : null | |||
| # tflint-ignore: terraform_unused_declarations | |||
| validate_metrics = var.plan != "enterprise-3nodes-2tb" && length(var.metrics) > 0 ? tobool("metrics are only supported for enterprise plan") : true | |||
| # tflint-ignore: terraform_unused_declarations | |||
| validate_schema_global_rule = var.plan != "enterprise-3nodes-2tb" && var.schema_global_rule != "" ? tobool("schema global rule is only supported for enterprise plan") : true | |||
There was a problem hiding this comment.
as per https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/pull/342/files#r1848885092 - default to null and not ""
kccox
force-pushed
the
add-schema-global-rule
branch
from
03468c8 to
712bd36
Compare
|
@ocofaigh Updated to use null as default value. I had to rewrite the validation check condition as otherwise terraform complained that |
ocofaigh
previously approved these changes
Nov 20, 2024
|
/run pipeline |
|
/run pipeline |
ocofaigh
reviewed
Nov 20, 2024
ocofaigh
reviewed
Nov 20, 2024
ocofaigh
requested changes
Nov 20, 2024
|
/run pipeline |
ocofaigh
approved these changes
Nov 20, 2024
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/IBM-Cloud/terraform-provider-ibm release v1.71.0 adds the
"ibm_event_streams_schema_global_rule"resource. This adds the global rule to the modules.Release required?
x.x.X)x.X.x)X.x.x)Release notes content
An instance of
"ibm_event_streams_schema_global_rule"sets the global compatibility rule for the Event Streams instance. This feature is only available for the Enterprise plan. The rule defines how the Event Streams schema registry will validate changes to a schema definition.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers