Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set limit on the terraform version #97

Merged
merged 11 commits into from
Oct 9, 2023
Merged

fix: set limit on the terraform version #97

merged 11 commits into from
Oct 9, 2023

Conversation

Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Oct 5, 2023 •
edited
Loading

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 5, 2023

/run pipeline

@Aashiq-J Aashiq-J closed this Oct 5, 2023
@Aashiq-J Aashiq-J reopened this Oct 5, 2023
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 5, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 5, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 5, 2023

/run pipeline

3 similar comments
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 5, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 5, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 6, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 6, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 6, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 6, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 6, 2023

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 6, 2023

/run pipeline

@Aashiq-J Aashiq-J changed the title fix: make loop nonsensitive fix: set limit on the terraform version Oct 6, 2023
@Aashiq-J Aashiq-J marked this pull request as ready for review October 6, 2023 09:37
@Aashiq-J Aashiq-J requested a review from ocofaigh October 6, 2023 09:38
ocofaigh
ocofaigh requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please set in the fscloud module, and all examples too please?

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Oct 9, 2023

/run pipeline

@Aashiq-J Aashiq-J requested a review from ocofaigh October 9, 2023 05:20
@ocofaigh ocofaigh merged commit 10c6de0 into main Oct 9, 2023
@ocofaigh ocofaigh deleted the nonsensitive branch October 9, 2023 12:00
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@akocbek akocbek mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aashiq-J @terraform-ibm-modules-ops @ocofaigh