Skip to content
This repository has been archived by the owner on Sep 21, 2020. It is now read-only.

Add new connection strategies and mark strategy as required #6

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Add new connection strategies and mark strategy as required #6

merged 1 commit into from
Feb 19, 2020

Conversation

dmcgee-ripple
Copy link
Contributor

New values (apple, oidc, line) are from the documentation. I left the string list in the code in the same non-alphabetical order as the upstream documentation so it is easier to see what might change in the future.
https://auth0.com/docs/api/management/v2#!/Connections/post_connections

Additionally, strategy has been marked as required as the API states
it is a mandatory parameter.

Open question- does it make sense to validate these since the list can continue to be updated in the future? Or is there a validator that will warn (but not reject) unknown but possibly valid values?

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

New values (`apple`, `oidc`, `line`) are from the documentation:
https://auth0.com/docs/api/management/v2#!/Connections/post_connections

Additionally, `strategy` has been marked as required as the API states
it is a mandatory parameter.
@benjigoldberg
Copy link

I just came here to see if this was under development! +1 would love this functionality. Thank you for contributing this!

@dmcgee-ripple
Copy link
Contributor Author

I'm not sure what is going on with the Label Github action, but maybe it isn't working since this PR is in a fork? Let me know if there is something I need to do to make that work.

@alexkappa
Copy link
Contributor

Hi Dan, thank you for submitting this! I'll give it a test and merge it in.

Or is there a validator that will warn (but not reject) unknown but possibly valid values?

Indeed, there is a warning mechanism we can use. We just need to write it ourselves cause the terraform sdk doesn't come with one as far as I know. It's probably a good idea to do that, so we can support new connection types as they become available.

@alexkappa alexkappa merged commit a4ede3a into hashicorp:master Feb 19, 2020
@benjigoldberg
Copy link

@alexkappa thanks for merging this! Any chance we could cut a new release? We'd love to take advantage of this feature

@alexkappa
Copy link
Contributor

I asked hashicorp for a new release but they haven't gotten around to it yet. I will ping again.

Meanwhile you could use the v0.5.2 from the original repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants