Skip to content
This repository has been archived by the owner on Sep 21, 2020. It is now read-only.

add auth0_prompt resource #8

Merged
merged 1 commit into from
Mar 23, 2020
Merged

add auth0_prompt resource #8

merged 1 commit into from
Mar 23, 2020

Conversation

apricote
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Changes proposed in this pull request:

Output from acceptance testing:

$ make testacc TESTS=TestAccPrompt
==> Checking that code complies with gofmt requirements...
?       github.com/terraform-providers/terraform-provider-auth0 [no test files]
=== RUN   TestAccPrompt
--- PASS: TestAccPrompt (1.95s)
PASS
coverage: 5.7% of statements
ok      github.com/terraform-providers/terraform-provider-auth0/auth0   1.960s  coverage: 5.7% of statements
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/terraform-providers/terraform-provider-auth0/auth0/internal/random   0.010s  coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/terraform-providers/terraform-provider-auth0/auth0/internal/validation       0.007s  coverage: 0.0% of statements [no tests to run]
...

@alexkappa
Copy link
Contributor

Thanks for giving this a go @apricote. Looks pretty good!

@apricote
Copy link
Contributor Author

I justed rebased on the current master. The TravisCI build failure does not seem related to my changes.

@alexkappa
Copy link
Contributor

Thank you @apricote, this makes my life easier :) I'm running the tests now and will be able to merge if all is well.

@alexkappa alexkappa merged commit bd185d3 into hashicorp:master Mar 23, 2020
@apricote apricote deleted the add-prompt-resource branch March 23, 2020 10:33
@alexkappa
Copy link
Contributor

I just had to update the imports to v4 of the SDK as I've updated it recently. Thanks again, Julian!

@apricote
Copy link
Contributor Author

Glad to see it merged so soon :) Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants