Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set WebsiteRedirect on S3 object #1020

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Allow to set WebsiteRedirect on S3 object #1020

merged 1 commit into from
Jun 30, 2017

Conversation

sugdyzhekov
Copy link
Contributor

The PR introduces support website redirect property of S3 bucket object.

@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 30, 2017
@stack72 stack72 self-assigned this Jun 30, 2017
@stack72
Copy link
Contributor

stack72 commented Jun 30, 2017

Hi @sugdyzhekov

Thanks so much for this (and your first contribution to Terraform!) This LGTM! The tests are also healthy

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3BucketObject_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSS3BucketObject_ -timeout 120m
=== RUN   TestAccAWSS3BucketObject_source
--- PASS: TestAccAWSS3BucketObject_source (67.54s)
=== RUN   TestAccAWSS3BucketObject_content
--- PASS: TestAccAWSS3BucketObject_content (85.05s)
=== RUN   TestAccAWSS3BucketObject_withContentCharacteristics
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (68.48s)
=== RUN   TestAccAWSS3BucketObject_updates
--- PASS: TestAccAWSS3BucketObject_updates (110.91s)
=== RUN   TestAccAWSS3BucketObject_updatesWithVersioning
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (111.38s)
=== RUN   TestAccAWSS3BucketObject_kms
--- PASS: TestAccAWSS3BucketObject_kms (108.46s)
=== RUN   TestAccAWSS3BucketObject_sse
--- PASS: TestAccAWSS3BucketObject_sse (80.69s)
=== RUN   TestAccAWSS3BucketObject_acl
--- PASS: TestAccAWSS3BucketObject_acl (136.51s)
=== RUN   TestAccAWSS3BucketObject_storageClass
--- PASS: TestAccAWSS3BucketObject_storageClass (137.40s)
=== RUN   TestAccAWSS3BucketObject_tags
--- PASS: TestAccAWSS3BucketObject_tags (66.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	973.037s

Thanks again

Paul

@stack72 stack72 merged commit 9babe80 into hashicorp:master Jun 30, 2017
@sugdyzhekov
Copy link
Contributor Author

Great! Thank you.

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants