Add support for Api Gateway method request validators. #1064
Conversation
| return nil | ||
| } | ||
|
|
||
| if !ok { |
There was a problem hiding this comment.
I adapted the delete function from aws_api_gateway_method. But, it seems to me that this if statement is not necessary (neither in this file nor in the other one).
In addition to that, I have realized that deleting a request validator might be more similar to deleting an authorizer (as seen here). That method contains the following comment:
// XXX: Figure out a way to delete the method that depends on the authorizer first
// otherwise the authorizer will be dangling until the API is deleted
The same thing happens for a request validator. If it is deleted before the method that uses it, AWS returns an error. Has any solution been found to that issue?
| if s := v.(string); len(s) > 0 { | ||
| request_validator_id = &s | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we need to compare the old value here with the new one. If the old one is an ID, and the new one is "", then we're deleting a request valuator, and we should issue a remove update here on the method, correct? It doesn't look like we can otherwise remove anything as-is
There was a problem hiding this comment.
I checked this out and tried manually, it seems we're sending nil in the operations below which is effectively doing what we want and removing it, so I guess this is fine 👍
|
The missing documentation has been submitted: #5110 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
This PR should fix terraform-providers#772