Addresses a number of issues with blocks in aws_codedeploy_deployment_group

[gdavison]

Unexpected behaviour occurs with some block attributes of aws_codedeploy_deployment_group when blocks are updated or deleted.

This PR now:

• Actually deletes load_balancer_info via the API and state when the block is removed from the resource configuration. This would also previously prevent setting values on load_balancer_info if it had been removed from the configuration. See aws_codedeploy_deployment_group issues with load_balancer_info #10836
• Now resets deployment_style to defaults if it is removed from configuration. Previously, this would do nothing to the resource in AWS.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10836

Release note for CHANGELOG:

resource/aws_codedeploy_deployment_group: Fixes unexpected behaviour when removing block attributes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeDeployDeploymentGroup_'

--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (47.18s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (49.10s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (49.55s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (53.70s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (53.85s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (56.37s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (58.31s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (61.30s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (62.70s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create (62.74s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (62.94s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (62.96s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (65.49s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (69.96s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (71.69s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (73.06s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (38.72s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (87.97s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (87.97s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_update (89.99s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (49.61s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (43.70s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (47.37s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (53.27s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (44.53s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (64.19s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (53.30s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (61.17s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (64.07s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (137.16s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (177.98s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen (308.25s)

[aeschright]

Since you're in here, you can clean up those foo bits to be our standard test naming.

[aeschright]

👍

--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (28.53s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_update (40.55s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (41.86s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (43.50s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (43.85s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (47.80s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create (48.43s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (57.04s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (57.72s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (58.83s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (58.88s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (60.46s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (62.00s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (66.91s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (67.40s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (46.79s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (75.66s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (42.97s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (40.18s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (88.18s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (45.64s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (47.15s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (51.68s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (54.50s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (39.90s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (39.73s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (41.48s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (39.94s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (56.12s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (132.81s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (148.93s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen (280.61s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!