Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure nil is not passed to RetryError helpers #14104

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Ensure nil is not passed to RetryError helpers #14104

merged 1 commit into from
Jul 13, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jul 8, 2020 •
edited
Loading

V2 of the SDK now errors if nil is passed to either of the RetryError helpers, this is to avoid subtle logical bugs. Certain patterns which naively return resource.NonRetryableError(err) when err == nil as a convenience to bubbling up nil should be avoided in favor of explicit error checking. It's possible this PR fixes some bugs in the wild 🤷‍♂️, main goal is to remove noise from V2 SDK acceptance tests.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team July 8, 2020 23:09
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. service/cloudwatchevents service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/redshift Issues and PRs that pertain to the redshift service. service/ssm Issues and PRs that pertain to the ssm service. labels Jul 8, 2020
@bflad bflad mentioned this pull request Jul 8, 2020
Closed
18 tasks
@appilon appilon force-pushed the td-fix-nil-retryable-nonretryable branch from adff930 to f6e54a0 Compare July 8, 2020 23:26
@bflad bflad modified the milestones: v2.70.0, v3.0.0 Jul 9, 2020
@bflad bflad self-assigned this Jul 9, 2020
bflad
bflad approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (Acceptance testing looked fine, but it was a lot so omitting here 😉 )

@appilon appilon merged commit ea377c4 into master Jul 13, 2020
@appilon appilon deleted the td-fix-nil-retryable-nonretryable branch July 13, 2020 16:11
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/acm Issues and PRs that pertain to the acm service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/redshift Issues and PRs that pertain to the redshift service. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@appilon @bflad