Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/ecr_repository: safely handle nil encryption information returned from API #14584

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 11, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14536

Release note for CHANGELOG:

resource/ecr_repository: safely handle nil encryption information returned from API

Output from acceptance testing (no new test added; unable to reproduce scenario although API docs do show a Sample Response where the field is omitted: https://docs.aws.amazon.com/AmazonECR/latest/APIReference/API_CreateRepository.html):

--- PASS: TestAccAWSEcrRepositoryDataSource_nonExistent (7.02s)
--- PASS: TestAccAWSEcrRepositoryDataSource_basic (29.16s)
--- PASS: TestAccAWSEcrRepositoryDataSource_encryption (31.80s)
--- PASS: TestAccAWSEcrRepository_basic (33.58s)
--- PASS: TestAccAWSEcrRepository_immutability (34.56s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (35.06s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (43.75s)
--- PASS: TestAccAWSEcrRepository_tags (44.43s)
--- PASS: TestAccAWSEcrRepository_encryption_kms (49.44s)
--- PASS: TestAccAWSEcrRepository_encryption_aes256 (53.68s)
--- PASS: TestAccAWSEcrRepository_image_scanning_configuration (61.71s)

@anGie44 anGie44 requested a review from a team August 11, 2020 21:23
@ghost ghost added service/ecr Issues and PRs that pertain to the ecr service. size/XS Managed by automation to categorize the size of a PR. labels Aug 11, 2020
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Aug 11, 2020
@bflad bflad added the crash Results from or addresses a Terraform crash or kernel panic. label Aug 12, 2020
@bflad bflad added this to the v3.2.0 milestone Aug 12, 2020
@bflad bflad self-assigned this Aug 12, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEcrRepositoryDataSource_nonExistent (6.03s)
--- PASS: TestAccAWSEcrRepositoryDataSource_basic (29.95s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (31.54s)
--- PASS: TestAccAWSEcrRepository_basic (32.45s)
--- PASS: TestAccAWSEcrRepositoryDataSource_encryption (32.60s)
--- PASS: TestAccAWSEcrRepository_immutability (32.98s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (42.06s)
--- PASS: TestAccAWSEcrRepository_tags (43.93s)
--- PASS: TestAccAWSEcrRepository_encryption_kms (47.00s)
--- PASS: TestAccAWSEcrRepository_encryption_aes256 (50.76s)
--- PASS: TestAccAWSEcrRepository_image_scanning_configuration (55.61s)

@anGie44 anGie44 merged commit 2de31ed into master Aug 12, 2020
@anGie44 anGie44 deleted the b-ecr-resource-crash branch August 12, 2020 21:26
anGie44 added a commit that referenced this pull request Aug 12, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/ecr Issues and PRs that pertain to the ecr service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.0 release cause a "TERRAFORM CRASH" with ECR resource
2 participants