Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s3 bucket data source #1505

Merged
merged 5 commits into from
Oct 11, 2017
Merged

Add s3 bucket data source #1505

merged 5 commits into from
Oct 11, 2017

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Aug 25, 2017

Started creating s3 bucket data source. Solves for #1262.

Please let me know if I'm missing anything.

@grubernaut grubernaut added enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. labels Aug 25, 2017
radeksimko
radeksimko approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kl4w
Thank you for the contribution.
I made the a few minor tweaks (related to conventions we follow elsewhere in the provider codebase) in 2 commits to speed things up as your PR otherwise looked small & simple and ready for merge. I hope you don't mind.

Your contribution is still included (and still credited to you), with the appropriate modifications. Feel free to ask about any of the changes.

@radeksimko radeksimko merged commit 5f3605b into hashicorp:master Oct 11, 2017
@kl4w
Copy link
Contributor Author

kl4w commented Oct 11, 2017

@radeksimko
Ahh cheers, that's perfect.
I'll keep an eye out for that in the future.

Thank you very much

@kl4w kl4w deleted the data_source_s3_bucket branch October 12, 2017 13:10
This was referenced Oct 16, 2017
Closed
Merged
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kl4w @radeksimko @grubernaut