Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/redshift_cluster: Make master_username ForceNew #2202

Merged
merged 2 commits into from
Nov 8, 2017
Merged

r/redshift_cluster: Make master_username ForceNew #2202

merged 2 commits into from
Nov 8, 2017

Conversation

radeksimko
Copy link
Member

This field is not updatable per API docs: http://docs.aws.amazon.com/redshift/latest/APIReference/API_ModifyCluster.html

Test Results

TF_ACC=1 go test ./aws -v -run=TestAccAWSRedshiftCluster_forceNewUsername -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_forceNewUsername
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1449.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1449.644s

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Nov 7, 2017
tombuildsstuff
tombuildsstuff approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

aws/resource_aws_redshift_cluster_test.go Outdated
@@ -320,6 +320,37 @@ func TestAccAWSRedshiftCluster_tags(t *testing.T) {
})
}

func TestAccAWSRedshiftCluster_forceNewUsername(t *testing.T) {
var v redshift.Cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor as you're storing this you could compare the old and new clusters to ensure it's been recreated?

@radeksimko radeksimko force-pushed the b-redshift-forcenew-username branch from 6c6ca26 to 069cd2d Compare November 8, 2017 10:49
@radeksimko radeksimko merged commit 88c9e04 into master Nov 8, 2017
@radeksimko radeksimko deleted the b-redshift-forcenew-username branch November 8, 2017 11:28
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @tombuildsstuff