Adjust aws_dynamodb_table CreateTable LimitExceededException handling for different error messaging #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for different error messaging
This was referenced Nov 14, 2017
radeksimko
suggested changes
Nov 15, 2017
aws/resource_aws_dynamodb_table.go
Outdated
| // Subscriber limit exceeded: There is a limit of 256 tables per subscriber | ||
| // Do not error out on this similar throttling message: | ||
| // Subscriber limit exceeded: Only 10 tables can be created, updated, or deleted simultaneously | ||
| if strings.Contains(awsErr.Message(), "Subscriber limit exceeded:") && !strings.Contains(awsErr.Message(), "simultaneously") { |
There was a problem hiding this comment.
Do you mind tightening this a little bit, just to make sure we don't match an error we don't want to match? e.g. can be created, updated, or deleted simultaneously?
There was a problem hiding this comment.
Not a problem at all - will update shortly
There was a problem hiding this comment.
Not a problem at all - will update shortly
radeksimko
added
bug
…ption retry message handling
|
Updated message matching pushed. 👍 |
radeksimko
removed
the
waiting-response
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS API is returning multiple, similar messages for DynamoDB throttling vs hitting the account limit. This "regression" was introduced in 130cdfe.
Closes #1776
Closes #2146