Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_sqs_queue #2311

Merged
merged 1 commit into from
Apr 11, 2018
Merged

New Data Source: aws_sqs_queue #2311

merged 1 commit into from
Apr 11, 2018

Conversation

idubinskiy
Copy link
Contributor

@idubinskiy idubinskiy commented Nov 15, 2017 •
edited by Ninir
Loading

Acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsSqsQueue'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsSqsQueue -timeout 120m
=== RUN   TestAccDataSourceAwsSqsQueue
--- PASS: TestAccDataSourceAwsSqsQueue (20.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.767s

Fixes #2822

@radeksimko radeksimko added new-data-source Introduces a new data source. size/L Managed by automation to categorize the size of a PR. labels Nov 16, 2017
Ninir
Ninir suggested changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @idubinskiy

This seems really good, thanks a lot for the work here! :) 👍

Just left a few things to discuss, mostly nitpicks :)

aws/data_source_aws_sqs_queue.go

d.Set("arn", *attributesOutput.Attributes[sqs.QueueAttributeNameQueueArn])
d.Set("url", queueURL)
d.SetId(queueURL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also set the other attributes, as in the resources, otherwise we would need to do it at some point. In the same way as the resource, could you do that? :)

aws/data_source_aws_sqs_queue_test.go
}

resource "aws_sqs_queue" "tf_wrong1" {
name = "wrong1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some randomization to the name here and below?

Ninir
Ninir reviewed Nov 21, 2017
View reviewed changes
website/docs/d/sqs_queue.html.markdown
Get information on an Amazon Simple Queue Service (SQS) Queue
---

# aws\_sqs\_queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, those antislashes are not needed anymore :)

@alexwlchan alexwlchan mentioned this pull request Jan 2, 2018
Closed
@radeksimko radeksimko added the service/sqs Issues and PRs that pertain to the sqs service. label Jan 17, 2018
@radeksimko radeksimko changed the title Add 'aws_sqs_queue' data source New Data Source: aws_sqs_queue Jan 17, 2018
@Ninir Ninir added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 30, 2018
@bflad
Copy link
Contributor

bflad commented Feb 14, 2018

@idubinskiy do you have time to work on this or would you like one of the maintainers to finish it?

@anthonyagresta
Copy link

Bumping this PR, would love for this to be a thing ❤️
@idubinskiy @bflad @Ninir

@bflad
Copy link
Contributor

bflad commented Apr 11, 2018

I'll finish this up.

@bflad bflad added this to the v1.15.0 milestone Apr 11, 2018
@bflad bflad merged commit 4519529 into hashicorp:master Apr 11, 2018
bflad added a commit that referenced this pull request Apr 11, 2018
@bflad
data-source/aws_sqs_queue: Implement #2311 feedback
bbefc33
bflad added a commit that referenced this pull request Apr 11, 2018
@bflad
Update CHANGELOG for #2311
7aec509
@bflad
Copy link
Contributor

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@idubinskiy idubinskiy deleted the data-source-sqs-queue branch April 26, 2018 18:58
@idubinskiy
Copy link
Contributor Author

@bflad Really appreciate you getting this in. Sorry that I didn't have the time to finish it up.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir requested changes

Assignees
No one assigned
Labels
new-data-source Introduces a new data source. service/sqs Issues and PRs that pertain to the sqs service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

There is no data source for SQS
6 participants
@idubinskiy @bflad @anthonyagresta @Ninir @breathingdust @radeksimko