Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_route53_query_log #2770

Merged
merged 1 commit into from
Jan 8, 2018
Merged

New Resource: aws_route53_query_log #2770

merged 1 commit into from
Jan 8, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 26, 2017

This could also live under aws_route53_zone, but AWS separated the API/IDs for some reason so to keep it future-proof I made it separate. If you want it combined into the existing resource, please let me know.

Closes #1764

make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53QueryLog'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSRoute53QueryLog -timeout 120m
=== RUN   TestAccAWSRoute53QueryLog_Basic
--- PASS: TestAccAWSRoute53QueryLog_Basic (47.49s)
=== RUN   TestAccAWSRoute53QueryLog_Import
--- PASS: TestAccAWSRoute53QueryLog_Import (45.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.181s

@bflad bflad mentioned this pull request Dec 26, 2017
Closed
@jen20 jen20 added new-resource Introduces a new resource. enhancement Requests to existing resources that expand the functionality or scope. labels Dec 26, 2017
radeksimko
radeksimko approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

aws/resource_aws_route53_query_log.go
if err != nil {
return fmt.Errorf("Error creating Route53 query logging configuration: %s", err)
}
log.Printf("[DEBUG] Route53 query logging configuration created: %#v", out)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but all AWS SDK structs have reasonable String() implementation, so it's safe (and usually better) to just use %s.

@radeksimko radeksimko merged commit 3bcdb0c into hashicorp:master Jan 8, 2018
@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@bflad bflad deleted the route53-query-logging branch January 12, 2018 14:51
@bflad
Copy link
Contributor Author

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Add support for dns query log configuration
3 participants
@bflad @radeksimko @jen20