Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_security_group: Allow empty rule description #2846

Merged
merged 2 commits into from
Feb 16, 2018
Merged

resource/aws_security_group: Allow empty rule description #2846

merged 2 commits into from
Feb 16, 2018

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Jan 3, 2018 

❯ make testacc TESTARGS="-run TestAccAWSSecurityGroup_emptyRuleDescription"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccAWSSecurityGroup_emptyRuleDescription -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSSecurityGroup_emptyRuleDescription
--- PASS: TestAccAWSSecurityGroup_emptyRuleDescription (195.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	196.033s

Fixes #2831.

@jen20 jen20 added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jan 3, 2018
@jen20 jen20 mentioned this pull request Jan 3, 2018
Closed
@radeksimko radeksimko changed the title r/aws_security_group: Allow empty rule description resource/aws_security_group: Allow empty rule description Jan 16, 2018
@radeksimko radeksimko self-assigned this Feb 16, 2018
radeksimko
radeksimko approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , thanks for the patch and sorry for the delay.

I just added tag to the VPC per convention set in #3392 and other PRs. This is to make it easier/possible for sweepers to find VPCs created by tests should they leak.

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 16, 2018
@radeksimko radeksimko merged commit 576b8ce into master Feb 16, 2018
@radeksimko radeksimko deleted the issue-2831 branch February 16, 2018 13:39
@bflad
Copy link
Contributor

bflad commented Feb 27, 2018

This has been released in version 1.10.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.10.0 milestone Feb 27, 2018
@antonbabenko antonbabenko mentioned this pull request Apr 23, 2018
Merged
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@radeksimko radeksimko

Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

aws_security_group_rule description validation is incorrect
3 participants
@jen20 @bflad @radeksimko