Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/ecr_lifecycle_policy: Support import #3246

Merged
merged 2 commits into from
Feb 5, 2018
Merged

resource/ecr_lifecycle_policy: Support import #3246

merged 2 commits into from
Feb 5, 2018

Conversation

atsushi-ishibashi
Copy link
Contributor 

TF_ACC=1 go test ./aws -v -run=TestAccAWSEcrLifecyclePolicy_* -timeout 120m
=== RUN   TestAccAWSEcrLifecyclePolicy_basic
--- PASS: TestAccAWSEcrLifecyclePolicy_basic (61.88s)
=== RUN   TestAccAWSEcrLifecyclePolicy_import
--- PASS: TestAccAWSEcrLifecyclePolicy_import (79.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	141.054s

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Feb 4, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. labels Feb 5, 2018
bflad
bflad approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcrLifecyclePolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEcrLifecyclePolicy -timeout 120m
=== RUN   TestAccAWSEcrLifecyclePolicy_basic
--- PASS: TestAccAWSEcrLifecyclePolicy_basic (12.82s)
=== RUN   TestAccAWSEcrLifecyclePolicy_import
--- PASS: TestAccAWSEcrLifecyclePolicy_import (12.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.601s

aws/resource_aws_ecr_lifecycle_policy.go
@@ -2,7 +2,6 @@ package aws

import (
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/awserr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 😀

@bflad bflad merged commit 01dbabc into hashicorp:master Feb 5, 2018
bflad added a commit that referenced this pull request Feb 5, 2018
@bflad
Update CHANGELOG for #3246
14202ca
@bflad bflad added this to the v1.9.0 milestone Feb 5, 2018
@bflad
Copy link
Contributor

bflad commented Feb 9, 2018

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad mentioned this pull request Mar 20, 2018
Closed
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushi-ishibashi @bflad