Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ses_domain_identity: Support trailing period in domain name #3840

Merged
merged 1 commit into from
Mar 20, 2018
Merged

resource/aws_ses_domain_identity: Support trailing period in domain name #3840

merged 1 commit into from
Mar 20, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 20, 2018

Closes #3836

Previously:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESDomainIdentity_trailingPeriod'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSESDomainIdentity_trailingPeriod -timeout 120m
=== RUN   TestAccAWSSESDomainIdentity_trailingPeriod
--- FAIL: TestAccAWSSESDomainIdentity_trailingPeriod (5.42s)
	testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:

		* aws_ses_domain_identity.test: 1 error(s) occurred:

		* aws_ses_domain_identity.test: Error requesting SES domain identity verification: InvalidParameterValue: Invalid domain name pkyjo4kn7f.terraformtesting.com..
			status code: 400, request id: a51106e2-2bed-11e8-8d72-954ea5c56c94
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	5.465s
make: *** [testacc] Error 1

Now:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSESDomainIdentity'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSESDomainIdentity -timeout 120m
=== RUN   TestAccAWSSESDomainIdentity_basic
--- PASS: TestAccAWSSESDomainIdentity_basic (11.63s)
=== RUN   TestAccAWSSESDomainIdentity_trailingPeriod
--- PASS: TestAccAWSSESDomainIdentity_trailingPeriod (14.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.132s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. labels Mar 20, 2018
@bflad bflad added this to the v1.12.0 milestone Mar 20, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Mar 20, 2018
@bflad bflad mentioned this pull request Mar 20, 2018
Closed
radeksimko
radeksimko approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship-it-ship-it-good

@bflad bflad merged commit c31bbcf into master Mar 20, 2018
@bflad bflad deleted the f-aws_ses_domain_identity-trailing-period branch March 20, 2018 12:53
bflad added a commit that referenced this pull request Mar 20, 2018
@bflad
Update CHANGELOG for #3840
c5f03a5
@bflad
Copy link
Contributor Author

bflad commented Mar 23, 2018

This has been released in version 1.12.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

aws_ses_domain_identity: Invalid domain name (trailing dot)
2 participants
@bflad @radeksimko