Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_autoscaling_group: Fix updating of service_linked_role #3942

Merged
merged 1 commit into from
Mar 28, 2018
Merged

resource/aws_autoscaling_group: Fix updating of service_linked_role #3942

merged 1 commit into from
Mar 28, 2018

Conversation

ungureanuvladvictor
Copy link
Contributor

@ungureanuvladvictor ungureanuvladvictor commented Mar 28, 2018

Currently terraform plan/apply show changes to the ASG but no real modifications are done to the infrastructure because the opts struct is unused at line 729.

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Mar 28, 2018
@radeksimko radeksimko added service/autoscaling Issues and PRs that pertain to the autoscaling service. bug Addresses a defect in current functionality. labels Mar 28, 2018
@bflad bflad added this to the v1.13.0 milestone Mar 28, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. 😓 Let's get this in.

@bflad bflad merged commit eee955e into hashicorp:master Mar 28, 2018
bflad added a commit that referenced this pull request Mar 28, 2018
@ungureanuvladvictor ungureanuvladvictor deleted the ungureanuvladvictor/fix-service-linked-role-update branch March 28, 2018 15:48
@ungureanuvladvictor
Copy link
Contributor Author

@bflad thx for getting this in! What is the usual cadence of releases for the AWS provider?

@bflad
Copy link
Contributor

bflad commented Mar 28, 2018

@bflad
Copy link
Contributor

bflad commented Mar 29, 2018

As soon as I say that we then cut an out of band release. 😅 This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants