Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_waf_regex_match_set #3947

Merged
merged 1 commit into from
Mar 28, 2018
Merged

New Resource: aws_waf_regex_match_set #3947

merged 1 commit into from
Mar 28, 2018

Conversation

radeksimko
Copy link
Member

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSWafRegexMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafRegexMatchSet_basic
--- PASS: TestAccAWSWafRegexMatchSet_basic (46.22s)
=== RUN   TestAccAWSWafRegexMatchSet_changePatterns
--- PASS: TestAccAWSWafRegexMatchSet_changePatterns (73.11s)
=== RUN   TestAccAWSWafRegexMatchSet_noPatterns
--- PASS: TestAccAWSWafRegexMatchSet_noPatterns (32.71s)
=== RUN   TestAccAWSWafRegexMatchSet_disappears
--- PASS: TestAccAWSWafRegexMatchSet_disappears (42.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	194.634s

@radeksimko radeksimko added new-resource Introduces a new resource. service/waf Issues and PRs that pertain to the waf service. labels Mar 28, 2018
@radeksimko radeksimko requested a review from appilon March 28, 2018 11:29
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Mar 28, 2018
appilon
appilon approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments, overall LGTM I'll leave the style suggestions up to your preference!

aws/resource_aws_waf_regex_match_set.go Outdated
StateFunc: func(v interface{}) string {
value := v.(string)
return strings.ToLower(value)
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one-liner? I'm not convinced either way it's good style but I'll suggest it and let you decide:

return strings.ToLower(v.(string))

aws/resource_aws_waf_regex_match_set.go Outdated
ChangeToken: token,
RegexMatchSetId: aws.String(d.Id()),
}
log.Printf("[INFO] Deleting WAF WAF Regex Match Set: %s", req)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: double WAF in message

aws/resource_aws_waf_regex_match_set_test.go Outdated
ChangeToken: token,
RegexMatchSetId: aws.String(*set.RegexMatchSetId),
}
log.Printf("[INFO] Deleting WAF WAF Regex Match Set: %s", req)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick double WAF

aws/resource_aws_waf_regex_match_set_test.go Outdated
}

for _, tuple := range set.RegexMatchTuples {
update := &waf.RegexMatchSetUpdate{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, consider 1 liner:

req.Updates = append(req.Updates, &waf.RegexMatchSetUpdate{
  Action: aws.String("DELETE"),
  RegexMatchTuple: tuple,
})

@radeksimko radeksimko force-pushed the f-waf-regex-match-set branch from e79b01f to bcdf5cb Compare March 28, 2018 14:16
@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Mar 28, 2018
@radeksimko
Copy link
Member Author

Thanks for the review, I believe I addressed all your feedback. 😉

@radeksimko radeksimko merged commit 95f0f8d into master Mar 28, 2018
@radeksimko radeksimko deleted the f-waf-regex-match-set branch March 28, 2018 14:21
@bflad bflad added this to the v1.13.0 milestone Mar 29, 2018
@bflad
Copy link
Contributor

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
new-resource Introduces a new resource. service/waf Issues and PRs that pertain to the waf service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radeksimko @bflad @appilon