Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_rds_cluster_instance: Prevent crash on importing non-cluster instances #3961

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 28, 2018

Reference: #3959

I'm not sure its possible to test importing the wrong resource type in the provider acceptance testing framework, but this nil check is to prevent:

panic: runtime error: invalid memory address or nil pointer dereference
2018-03-28T21:54:57.071+0300 [DEBUG] plugin.terraform-provider-aws_v1.12.0_x4: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x29b326b]
2018-03-28T21:54:57.071+0300 [DEBUG] plugin.terraform-provider-aws_v1.12.0_x4:
2018-03-28T21:54:57.071+0300 [DEBUG] plugin.terraform-provider-aws_v1.12.0_x4: goroutine 105 [running]:
2018-03-28T21:54:57.071+0300 [DEBUG] plugin.terraform-provider-aws_v1.12.0_x4: github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsRDSClusterInstanceRead(0xc42030e3f0, 0x324f740, 0xc420095180, 0xc42030e3f0, 0x0)
2018-03-28T21:54:57.071+0300 [DEBUG] plugin.terraform-provider-aws_v1.12.0_x4: 	/opt/teamcity-agent/work/222ea50a1b4f75f4/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_rds_cluster_instance.go:319 +0x17b

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/rds Issues and PRs that pertain to the rds service. labels Mar 28, 2018
@bflad bflad added this to the v1.13.0 milestone Mar 28, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Mar 28, 2018
@bflad bflad modified the milestones: v1.13.0, v1.14.0 Mar 29, 2018
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit ea9a08b into master Apr 5, 2018
@bflad bflad deleted the b-aws_rds_cluster_instance-prevent-regular-instance-import-crash branch April 5, 2018 16:52
bflad added a commit that referenced this pull request Apr 5, 2018
@bflad
Copy link
Contributor Author

bflad commented Apr 6, 2018

This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants