New Data Source: aws_lambda_invocation #4222

spirius · 2018-04-16T16:18:10Z

Data source for using lambda function as data provider, similar to External Data Source.

spirius · 2018-04-17T20:03:35Z

Test results

$ TF_ACC=1 go test -v -run=TestAccDataSourceAwsLambdaInvoke_* -timeout 120m
=== RUN   TestAccDataSourceAwsLambdaInvoke_basic
--- PASS: TestAccDataSourceAwsLambdaInvoke_basic (51.64s)
=== RUN   TestAccDataSourceAwsLambdaInvoke_qualifier
--- PASS: TestAccDataSourceAwsLambdaInvoke_qualifier (50.15s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws   101.834s

bflad

Hi @spirius! Thanks for submitting this! I left some initial comments below. Can you please take a look and let us know if you have any questions or do not have time to implement the feedback? 👍

bflad · 2018-04-25T18:12:50Z

aws/data_source_aws_lambda_invoke.go

+	"github.com/hashicorp/terraform/helper/schema"
+)
+
+func dataSourceAwsLambdaInvoke() *schema.Resource {


Can you please rename all the relevant functions to dataSourceAwsLambdaFunctionInvocation? Thanks!

bflad · 2018-04-25T18:20:19Z

aws/data_source_aws_lambda_invoke.go

+				Default:  "$LATEST",
+			},
+
+			"input": {


We should probably make this TypeString, which will allow us to use ValidateFunc: validateJsonString, and remove JSON marshal handling/errors from the data source.

bflad · 2018-04-25T20:10:28Z

aws/data_source_aws_lambda_invoke.go

+				},
+			},
+
+			"result": {


Same here -- we should convert this to TypeString and remove the JSON unmarshal handling/errors from the data source.

If we use TypeString for result, how the returned data will be used later in terraform code? As far as I know there is no jsondecode or similar function available.

bflad · 2018-04-25T20:13:00Z

aws/data_source_aws_lambda_invoke.go

+
+	res, err := conn.Invoke(&lambda.InvokeInput{
+		FunctionName:   aws.String(functionName),
+		InvocationType: aws.String(lambda.InvocationTypeRequestResponse),


In the future, we can allow a new invocation_type attribute for calling Lambda functions asynchronously with Event 👍

Exactly, I wanted to keep the first version simple, but I think we can pass some random s3 key to lambda during invocation and expect to get result stored there.

bflad · 2018-04-25T20:14:04Z

aws/provider.go

@@ -211,6 +211,7 @@ func Provider() terraform.ResourceProvider {
 			"aws_kms_ciphertext":                   dataSourceAwsKmsCiphertext(),
 			"aws_kms_key":                          dataSourceAwsKmsKey(),
 			"aws_kms_secret":                       dataSourceAwsKmsSecret(),
+			"aws_lambda_invoke":                    dataSourceAwsLambdaInvoke(),


Can you please rename the data source aws_lambda_function_invocation? Thanks!

… input field

PauloMigAlmeida · 2018-05-09T03:13:38Z

@spirius Apparently, there are conflicts with the master branch that need to be solved before anyone from Hashicorp can take further action on this. Would you mind addressing them?

@bflad Apart from these conflicts, what else needs to be done in order to get this approved/merged into master? I'm happy to contribute to it in any way possible.

Cheers!

spirius · 2018-05-11T09:15:31Z

@PauloMigAlmeida conflict fixed.

@bflad I've updated code according to your comments. The only question I have is regarding result field. If we use TypeString for it, how the result can be used later in terraform since it needs to be unmarshalled somehow and there is no builtin function in terraform for doing that.

bflad · 2018-05-11T15:19:42Z

For handling the response, what do you think about the below? 😄

Renaming the existing result attribute to result_map
Creating a new result attribute using TypeString with the "full" JSON string
Ensuring the logic is setup so it does not completely fail when the JSON cannot be unmarshalled into the map[string]interface{} (and document the behavior that the attribute will show as missing downstream if the JSON cannot be unmarshalled)

This enables these use cases:

Advanced operators that are comfortable with using null_resource or one of the community "JSON decoding" providers, can utilize the TypeString attribute today
When jsondecode is implemented as an interpolation function upstream in Terraform core, people can immediately use the TypeString attribute without AWS provider code changes. The jsondecode function is being tracked upstream at: jsondecode function terraform#10363
Operators can still use the limited TypeMap implementation today, if their Lambda response fits the mold

spirius · 2018-05-14T19:18:42Z

Hi @bflad, renamed result to result_map and added raw result to data source.

Test results:

$ TF_ACC=1 go test -v -run=TestAccDataSourceAwsLambdaInvocation_* -timeout 120m ./aws
=== RUN   TestAccDataSourceAwsLambdaInvocation_basic
--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (51.32s)
=== RUN   TestAccDataSourceAwsLambdaInvocation_qualifier
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (53.58s)
=== RUN   TestAccDataSourceAwsLambdaInvocation_complex
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (50.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	155.076s

bflad

Thanks for working through this @spirius! Looks great, I just needed to randomize the test resource naming so the testing could work in our parallelized acceptance testing environment.

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsLambdaInvocation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsLambdaInvocation -timeout 120m
=== RUN   TestAccDataSourceAwsLambdaInvocation_basic
--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (39.70s)
=== RUN   TestAccDataSourceAwsLambdaInvocation_qualifier
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (38.59s)
=== RUN   TestAccDataSourceAwsLambdaInvocation_complex
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (38.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	117.159s

bflad · 2018-05-17T21:38:22Z

This has been released in version 1.19.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-06T17:12:11Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added the size/L Managed by automation to categorize the size of a PR. label Apr 16, 2018

spirius force-pushed the feature/lambda-invoke branch from 6b1fc05 to 4d2952b Compare April 16, 2018 16:39

ghost added the size/L Managed by automation to categorize the size of a PR. label Apr 16, 2018

bflad added new-data-source Introduces a new data source. service/lambda Issues and PRs that pertain to the lambda service. labels Apr 17, 2018

Add aws_lambda_invoke data source

1e09e14

spirius force-pushed the feature/lambda-invoke branch from 4d2952b to 1e09e14 Compare April 17, 2018 19:57

ghost added the size/L Managed by automation to categorize the size of a PR. label Apr 17, 2018

Add d/aws_lambda_invoke link in website

72e0f02

spirius changed the title ~~[WIP] New Data Source: aws_lambda_invoke~~ New Data Source: aws_lambda_invoke Apr 17, 2018

bflad reviewed Apr 25, 2018

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 25, 2018

spirius added 2 commits April 28, 2018 15:05

Merge with master

e4bffe1

Rename aws_lambda_invoke to aws_lambda_invocation, use TypeString for…

80ca22f

… input field

ghost added the size/L Managed by automation to categorize the size of a PR. label Apr 28, 2018

spirius changed the title ~~New Data Source: aws_lambda_invoke~~ New Data Source: aws_lambda_invocation Apr 28, 2018

spirius added 2 commits May 11, 2018 11:07

Merge branch 'master'

27c8a53

Update docs for aws_lambda_invocation

c79c7a0

ghost added the size/L Managed by automation to categorize the size of a PR. label May 11, 2018

bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label May 11, 2018

Add raw result to aws_lambda_invocation data source

7c73567

ghost added the size/L Managed by automation to categorize the size of a PR. label May 14, 2018

bflad added this to the v1.19.0 milestone May 14, 2018

bflad approved these changes May 14, 2018

View reviewed changes

bflad merged commit 7c73567 into hashicorp:master May 14, 2018

bflad added a commit that referenced this pull request May 14, 2018

Update CHANGELOG for #4222

766323a

spirius deleted the feature/lambda-invoke branch May 15, 2018 14:09

Bhuwan mentioned this pull request Jul 2, 2018

New Resource: aws_custom_resource #3361

Closed

ghost locked and limited conversation to collaborators Apr 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Data Source: aws_lambda_invocation #4222

New Data Source: aws_lambda_invocation #4222

spirius commented Apr 16, 2018

spirius commented Apr 17, 2018

bflad left a comment

bflad Apr 25, 2018

bflad Apr 25, 2018

bflad Apr 25, 2018

spirius Apr 28, 2018

bflad Apr 25, 2018

spirius Apr 28, 2018

bflad Apr 25, 2018

PauloMigAlmeida commented May 9, 2018

spirius commented May 11, 2018

bflad commented May 11, 2018

spirius commented May 14, 2018

bflad left a comment

bflad commented May 17, 2018

ghost commented Apr 6, 2020

New Data Source: aws_lambda_invocation #4222

New Data Source: aws_lambda_invocation #4222

Conversation

spirius commented Apr 16, 2018

spirius commented Apr 17, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad Apr 25, 2018

Choose a reason for hiding this comment

bflad Apr 25, 2018

Choose a reason for hiding this comment

bflad Apr 25, 2018

Choose a reason for hiding this comment

spirius Apr 28, 2018

Choose a reason for hiding this comment

bflad Apr 25, 2018

Choose a reason for hiding this comment

spirius Apr 28, 2018

Choose a reason for hiding this comment

bflad Apr 25, 2018

Choose a reason for hiding this comment

PauloMigAlmeida commented May 9, 2018

spirius commented May 11, 2018

bflad commented May 11, 2018

spirius commented May 14, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad commented May 17, 2018

ghost commented Apr 6, 2020