Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_glue_job: Add timeout argument #4460

Merged
merged 1 commit into from
May 9, 2018
Merged

resource/aws_glue_job: Add timeout argument #4460

merged 1 commit into from
May 9, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 5, 2018

Closes #4332

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueJob'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueJob -timeout 120m
=== RUN   TestAccAWSGlueJob_Basic
--- PASS: TestAccAWSGlueJob_Basic (14.25s)
=== RUN   TestAccAWSGlueJob_AllocatedCapacity
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (21.51s)
=== RUN   TestAccAWSGlueJob_Command
--- PASS: TestAccAWSGlueJob_Command (21.32s)
=== RUN   TestAccAWSGlueJob_DefaultArguments
--- PASS: TestAccAWSGlueJob_DefaultArguments (21.88s)
=== RUN   TestAccAWSGlueJob_Description
--- PASS: TestAccAWSGlueJob_Description (20.10s)
=== RUN   TestAccAWSGlueJob_ExecutionProperty
--- PASS: TestAccAWSGlueJob_ExecutionProperty (21.57s)
=== RUN   TestAccAWSGlueJob_MaxRetries
--- PASS: TestAccAWSGlueJob_MaxRetries (20.74s)
=== RUN   TestAccAWSGlueJob_Timeout
--- PASS: TestAccAWSGlueJob_Timeout (21.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	163.323s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. labels May 5, 2018
@bflad bflad added this to the v1.18.0 milestone May 5, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label May 5, 2018
@bflad bflad mentioned this pull request May 5, 2018
Closed
mbfrahry
mbfrahry approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit f5fb026 into master May 9, 2018
@bflad bflad deleted the f-aws_glue_job-timeout branch May 9, 2018 19:57
bflad added a commit that referenced this pull request May 9, 2018
@bflad
Update CHANGELOG for #4460
fc309ae
@bflad
Copy link
Contributor Author

bflad commented May 10, 2018

This has been released in version 1.18.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Add timeout to the aws_glue_job resource
2 participants
@bflad @mbfrahry