Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect lambda function qualifier on data source. #4654

Merged
merged 1 commit into from
May 25, 2018

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented May 25, 2018

As written, the lambda function data source always returns the most
recent version and qualified arn, even if a different qualifier is set.
This patch respects the qualifier if provided.

As written, the lambda function data source always returns the most
recent version and qualified arn, even if a different qualifier is set.
This patch respects the qualifier if provided.
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label May 25, 2018
@jen20 jen20 added service/lambda Issues and PRs that pertain to the lambda service. bug Addresses a defect in current functionality. labels May 25, 2018
@jen20
Copy link
Contributor

jen20 commented May 25, 2018

Hi @jmcarp! Thanks for submitting a pull request. This does look like a correct change to me, however it doesn't match the pull request description, which describes the data source, whereas the change is to the resource variant of the Lambda function. Is this a change which needs propagating across to the data source also?

@jmcarp
Copy link
Contributor Author

jmcarp commented May 25, 2018

@jen20: this does affect the data source, since the resource and data source share the same read function. It might make sense to refactor to two separate functions for clarity, but I figured I'd try to keep the patch simple to start with.

@jen20
Copy link
Contributor

jen20 commented May 25, 2018

Ah yes, I see now. I'm not particularly sure I like the pattern of multiple resources sharing read functions, but this does fix the issue and that refactor can be made another time. Thanks for contributing!

@jen20 jen20 merged commit 29d6071 into hashicorp:master May 25, 2018
@bflad bflad added this to the v1.21.0 milestone May 31, 2018
@bflad
Copy link
Contributor

bflad commented May 31, 2018

This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants