Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting endpoint for EFS #4716

Merged
merged 1 commit into from
Jun 2, 2018
Merged

Allow setting endpoint for EFS #4716

merged 1 commit into from
Jun 2, 2018

Conversation

joseph-stratoscale
Copy link
Contributor

@joseph-stratoscale joseph-stratoscale commented May 31, 2018 •
edited
Loading

Adding support for setting user defined end-point

Changes proposed in this pull request:

  • provider.go
  • config.go
  • website/docs/index.html.markdown

Github issue
#3888

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 31, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 31, 2018
@bflad
Copy link
Contributor

bflad commented May 31, 2018 •
edited
Loading

Hi @joseph-stratoscale 👋 the provider/config changes look good, but I'm curious about the endpoint attribute addition to the resource. Nothing is setting that attribute (via d.Set("endpoint", ...)) in the resource currently. Seems like it should be removed.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 31, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 31, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 31, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 31, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 1, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 1, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 1, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 1, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 1, 2018
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 1, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. and removed size/S Managed by automation to categorize the size of a PR. labels Jun 1, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 1, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 1, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 1, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 1, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 1, 2018
@joseph-stratoscale
Allow setting endpoint for EFS
d53b1c2 
Adding support for setting user defined end-point
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Jun 1, 2018
@joseph-stratoscale
Copy link
Contributor Author

@bflad I made some modifications based on this Pull Request:
https://github.com/terraform-providers/terraform-provider-aws/pull/4670/files

@bflad bflad added this to the v1.22.0 milestone Jun 2, 2018
bflad
bflad approved these changes Jun 2, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @joseph-stratoscale! Thanks for catching the documentation update too 😄 🚀

Passes service smoke test:

1 test passed (all tests)
=== RUN   TestAccAWSEFSFileSystem_basic
--- PASS: TestAccAWSEFSFileSystem_basic (29.81s)
PASS

@bflad bflad merged commit cbba829 into hashicorp:master Jun 2, 2018
bflad added a commit that referenced this pull request Jun 2, 2018
@bflad
Update CHANGELOG for #4716
90b6c38
@bflad
Copy link
Contributor

bflad commented Jun 5, 2018

This has been released in version 1.22.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad mentioned this pull request Jun 28, 2018
Merged
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-stratoscale @bflad