Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_iam_user: Add permissions_boundary attribute #5187

Merged
merged 1 commit into from
Jul 16, 2018
Merged

data-source/aws_iam_user: Add permissions_boundary attribute #5187

merged 1 commit into from
Jul 16, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 13, 2018

Reference: #5174

Changes proposed in this pull request:

  • Add permissions boundary support to aws_iam_user data source
  • Minor refactoring for newer practices
  • Support AWS GovCloud (US) acceptance testing

Output from acceptance testing: AWS Commercial

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMUser_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMUser_basic -timeout 120m
=== RUN   TestAccAWSDataSourceIAMUser_basic
--- PASS: TestAccAWSDataSourceIAMUser_basic (10.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.924s

Output from acceptance testing: AWS GovCloud (US)

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMUser_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDataSourceIAMUser_basic -timeout 120m
=== RUN   TestAccAWSDataSourceIAMUser_basic
--- PASS: TestAccAWSDataSourceIAMUser_basic (19.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.240s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. labels Jul 13, 2018
@bflad bflad requested a review from a team July 13, 2018 17:46
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jul 13, 2018
@bflad bflad mentioned this pull request Jul 13, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Jul 15, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.28.0 milestone Jul 16, 2018
@bflad bflad merged commit f2c089d into master Jul 16, 2018
@bflad bflad deleted the f-aws_iam_user-ds-permissions_boundary branch July 16, 2018 16:43
bflad added a commit that referenced this pull request Jul 16, 2018
@bflad
Update CHANGELOG for #5187
ad79ce6
@bflad
Copy link
Contributor Author

bflad commented Jul 18, 2018

This has been released in version 1.28.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff