-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_storagegateway_nfs_file_share #5255
Conversation
bebbc13
to
c875593
Compare
…r_id to 65534 (nfsnobody UID/GID)
Squash: aws.String(d.Get("squash").(string)), | ||
} | ||
|
||
if v, ok := d.GetOk("kms_key_arn"); ok && v.(string) != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: isn't the && v.(string) != ""
unnecessary here? The ok
from GetOk
should denote if the value is the zero value. If the config omits kms_key_arn
then ok
here will be false, unless I'm not recalling correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the intention of these v.(string) != ""
checks with d.GetOk()
is for allowing modules to define ""
until null
is available in Terraform 0.12. If this is unnecessary with Terraform 0.11, we have a lot of code to clean up. 🙁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Reference: #943
Changes proposed in this pull request:
aws_storagegateway_nfs_file_share
Output from acceptance testing: