issue #5412 AWS SSM DoesNotExistException for missing Maintenance Window

[saravanan30erd]

Fixes #5412
Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSSMMaintenanceWindow_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSSSMMaintenanceWindow_basic -timeout 120m
=== RUN   TestAccAWSSSMMaintenanceWindow_basic
--- PASS: TestAccAWSSSMMaintenanceWindow_basic (69.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.112s
...

[bflad]

Can you please add an acceptance test to ensure we do not cause any regressions for this issue in the future? Testing inspiration can be found in #5401 for example.

[saravanan30erd]

@bflad added acceptance test. I thought its better not to touch the exists tests, so I created new resource Exists check function for this acceptance test. If its ok, then I ll modify the existing one and use.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSSMMaintenanceWindow_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSSSMMaintenanceWindow_disappears -timeout 120m
=== RUN TestAccAWSSSMMaintenanceWindow_disappears
--- PASS: TestAccAWSSSMMaintenanceWindow_disappears (33.42s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 33.457s

[bflad]

Feel free to modify the existing Exists function to also set a *ssm.MaintenanceWindowIdentity instead of creating a new function; that's how we do it for other resource testing. 👍

[saravanan30erd]

@bflad Done 👍

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSSMMaintenanceWindow_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSSSMMaintenanceWindow_ -timeout 120m
=== RUN TestAccAWSSSMMaintenanceWindow_basic
--- PASS: TestAccAWSSSMMaintenanceWindow_basic (65.15s)
=== RUN TestAccAWSSSMMaintenanceWindow_disappears
--- PASS: TestAccAWSSSMMaintenanceWindow_disappears (29.25s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 94.454s

[bflad]

Looks great, thanks so much @saravanan30erd! 🚀

6 tests passed (all tests)
=== RUN   TestAccAWSSSMMaintenanceWindow_disappears
--- PASS: TestAccAWSSSMMaintenanceWindow_disappears (3.11s)
=== RUN   TestAccAWSSSMMaintenanceWindowTarget_basic
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_basic (4.27s)
=== RUN   TestAccAWSSSMMaintenanceWindow_basic
--- PASS: TestAccAWSSSMMaintenanceWindow_basic (6.42s)
=== RUN   TestAccAWSSSMMaintenanceWindowTarget_update
--- PASS: TestAccAWSSSMMaintenanceWindowTarget_update (6.78s)
=== RUN   TestAccAWSSSMMaintenanceWindowTask_basic
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (216.03s)
=== RUN   TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (240.19s)

[bflad]

This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!