Add support for 'redirect' and 'fixed-response' into lb_listener and lb_listener_rule

[jianyuan]

Fixes #5344.

Changes proposed in this pull request:

• Add support for redirect and fixed-response into lb_listener.
• Add support for redirect and fixed-response into lb_listener_rule.
• Updated docs.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBListener\(Rule\)?'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLBListener\(Rule\)? -timeout 120m
=== RUN   TestAccAWSLBListenerRule_basic
--- PASS: TestAccAWSLBListenerRule_basic (223.11s)
=== RUN   TestAccAWSLBListenerRuleBackwardsCompatibility
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (250.42s)
=== RUN   TestAccAWSLBListenerRule_redirect
--- PASS: TestAccAWSLBListenerRule_redirect (234.50s)
=== RUN   TestAccAWSLBListenerRule_fixedResponse
--- PASS: TestAccAWSLBListenerRule_fixedResponse (221.45s)
=== RUN   TestAccAWSLBListenerRule_updateRulePriority
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (338.63s)
=== RUN   TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (265.98s)
=== RUN   TestAccAWSLBListenerRule_multipleConditionThrowsError
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (1.53s)
=== RUN   TestAccAWSLBListenerRule_priority
--- PASS: TestAccAWSLBListenerRule_priority (429.05s)
=== RUN   TestAccAWSLBListener_basic
--- PASS: TestAccAWSLBListener_basic (233.51s)
=== RUN   TestAccAWSLBListenerBackwardsCompatibility
--- PASS: TestAccAWSLBListenerBackwardsCompatibility (230.56s)
=== RUN   TestAccAWSLBListener_https
--- PASS: TestAccAWSLBListener_https (243.43s)
=== RUN   TestAccAWSLBListener_redirect
--- PASS: TestAccAWSLBListener_redirect (232.45s)
=== RUN   TestAccAWSLBListener_fixedResponse
--- PASS: TestAccAWSLBListener_fixedResponse (236.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3140.836s

[melo]

Any idea when this PR will have a milestone associated?

Thank you

[bflad]

@melo it will generally receive a milestone right before merge unless its an important bug/crash fix

[danielpereira-hotmart]

ok!

[bacoboy]

Unfortunately AWS doesn't support custom headers in the fixed-response (for like an HSTS header), but AWS support said they'd take it under advisement. Just an FYI for the group...

[bflad]

Nice work, @jianyuan! LGTM 🚀

(Test failure unrelated)

Tests failed: 1 (1 new), passed: 12
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (1.50s)
--- PASS: TestAccAWSLBListenerRule_basic (174.19s)
--- PASS: TestAccAWSLBListener_basic (175.31s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (190.57s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (193.58s)
--- PASS: TestAccAWSLBListener_redirect (193.93s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (198.41s)
--- PASS: TestAccAWSLBListener_https (199.13s)
--- PASS: TestAccAWSLBListenerRule_redirect (200.23s)
--- PASS: TestAccAWSLBListener_fixedResponse (200.61s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (203.08s)
--- PASS: TestAccAWSLBListenerBackwardsCompatibility (217.40s)
--- FAIL: TestAccAWSLBListenerRule_priority (238.18s)

[tdmalone]

Thanks so much @jianyuan!

[bflad]

This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[stszap]

Thanks to all who contributed to add this feature, it is awesome! I can specify path = "#{path}" and terrafrom tries to create a listener but gets an error from aws:

* aws_lb_listener.external_http: Error creating LB Listener: InvalidLoadBalancerAction: The Path parameter must be a valid path, should start with a '/', and may contain up to one of each of these placeholders: '#{path}', '#{host}', '#{port}'.
	status code: 400, request id: febe9779-a6a8-11e8-9d4a-818ad1227d6

It works withpath = "/#{path}"but maybe there should be an additional check for leading "/" just to fail faster?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!