vendor: hashicorp/go-multierror@3d5d8f294aa03d8e98859feac328afbdf1ae0703 #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
dependencies
ghost
added
size/M
|
This has been released in version 1.31.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
bflad
added a commit
that referenced
this pull request
Aug 12, 2018
…rror conditions In #5442 (vendor: hashicorp/go-multierror@3d5d8f2), the output formatting for go-multierror changed which included an additional newline after the final error message. These two acceptance tests were too strict with their ExpectError regex validation and extraneously checking whitespace handling outside the returned error. Previously: --- FAIL: TestAccAWSDynamoDbTable_attributeUpdateValidation (0.93s) testing.go:511: Step 0, expected error: Error planning: 1 error occurred: * aws_dynamodb_table.basic-dynamodb-table: 1 error occurred: * aws_dynamodb_table.basic-dynamodb-table: All attributes must be indexed. Unused attributes: ["unusedKey"] To match: All attributes must be indexed. Unused attributes: \["unusedKey"\]$ --- FAIL: TestAccAWSDynamoDbTable_streamSpecificationValidation (0.86s) testing.go:511: Step 0, expected error: Error planning: 1 error occurred: * aws_dynamodb_table.basic-dynamodb-table: 1 error occurred: * aws_dynamodb_table.basic-dynamodb-table: stream_view_type is required when stream_enabled = true To match: stream_view_type is required when stream_enabled = true$ Now: make testacc TEST=./aws TESTARGS='-run=TestAccAWSDynamoDbTable_\(attributeUpdate\|streamSpecification\)Validation' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSDynamoDbTable_\(attributeUpdate\|streamSpecification\)Validation -timeout 120m === RUN TestAccAWSDynamoDbTable_streamSpecificationValidation --- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (2.89s) === RUN TestAccAWSDynamoDbTable_attributeUpdateValidation --- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (3.80s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 7.317s
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
govendor fetch github.com/hashicorp/go-multierror/...@3d5d8f294aa03d8e98859feac328afbdf1ae0703Output from acceptance testing: Handled via daily acceptance testing