Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_source/aws_route53_delegation_set: adding new data source for route53 #6152

Merged
merged 4 commits into from
Nov 25, 2018
Merged

data_source/aws_route53_delegation_set: adding new data source for route53 #6152

merged 4 commits into from
Nov 25, 2018

Conversation

slapula
Copy link
Contributor

@slapula slapula commented Oct 14, 2018 •
edited
Loading

Fixes #6073

Changes proposed in this pull request:

  • Adding aws_route53_delegation_set data source

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceRoute53DelegationSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccDataSourceRoute53DelegationSet_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceRoute53DelegationSet_basic
--- PASS: TestAccDataSourceRoute53DelegationSet_basic (68.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.656s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 14, 2018
bflad
bflad reviewed Oct 14, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @slapula! Initial comments below. Please let us know if you have any questions or do not have time to implement these items.

aws/data_source_aws_route53_delegation_set.go Outdated Show resolved Hide resolved
aws/data_source_aws_route53_delegation_set.go Outdated Show resolved Hide resolved
aws/data_source_aws_route53_delegation_set.go Outdated Show resolved Hide resolved
aws/data_source_aws_route53_delegation_set_test.go Show resolved Hide resolved
website/docs/d/route53_delegation_set.html.markdown Show resolved Hide resolved
aws/provider.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 14, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Oct 24, 2018
@bflad
Copy link
Contributor

bflad commented Nov 13, 2018

Hi @slapula 👋 Are you planning on addressing the feedback any time soon? No worries if not, we generally would like to reduce the open pull request count to those that are in progress.

@slapula
Copy link
Contributor Author

slapula commented Nov 14, 2018

@bflad Yup! This is just a busy time of year for me and I haven't been able to circle back to these PRs yet. They are still on my radar though.

@ghost ghost added provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 21, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 25, 2018
@slapula
Copy link
Contributor Author

slapula commented Nov 25, 2018

@bflad I believe I've addressed your comments here. Let me know if there's anything else I need to take a look at.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 25, 2018
bflad
bflad approved these changes Nov 25, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @slapula! 🚀

--- PASS: TestAccDataSourceRoute53DelegationSet_basic (42.83s)

@bflad bflad added this to the v1.47.0 milestone Nov 25, 2018
@bflad bflad merged commit 4b57d18 into hashicorp:master Nov 25, 2018
bflad added a commit that referenced this pull request Nov 25, 2018
@bflad
Update CHANGELOG for #6152
efde785
@bflad bflad added the new-data-source Introduces a new data source. label Nov 25, 2018
@bflad
Copy link
Contributor

bflad commented Nov 30, 2018

This was released (4 days ago) in version 1.47.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@briceburg briceburg mentioned this pull request Jun 12, 2019
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.47.0
Development

Successfully merging this pull request may close these issues.

No data source for aws_route53_delegation_set
2 participants
@slapula @bflad