Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ForceNew for s3_backup_mode in aws_kinesis_firehose_delivery_stream #6305

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Set ForceNew for s3_backup_mode in aws_kinesis_firehose_delivery_stream #6305

merged 1 commit into from
Oct 31, 2018

Conversation

Hinidu
Copy link
Contributor

@Hinidu Hinidu commented Oct 30, 2018

Fixes #1369

Changes proposed in this pull request:

  • Set ForceNew: true for s3_backup_mode attribute of aws_kinesis_firehose_delivery_stream resource because it can't be changed on existing delivery stream.

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/firehose Issues and PRs that pertain to the firehose service. labels Oct 30, 2018
@bflad bflad added the bug Addresses a defect in current functionality. label Oct 30, 2018
bflad
bflad suggested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hinidu 👋 Thanks for submitting this. We currently implement the S3, Redshift, and Splunk updates for S3 backup mode. It appears only Elasticsearch update doesn't support update of this parameter via the API. Please revert the changes to the other attributes.

aws/resource_aws_kinesis_firehose_delivery_stream.go Outdated Show resolved Hide resolved
aws/resource_aws_kinesis_firehose_delivery_stream.go Outdated Show resolved Hide resolved
aws/resource_aws_kinesis_firehose_delivery_stream.go Show resolved Hide resolved
aws/resource_aws_kinesis_firehose_delivery_stream.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 30, 2018
@bflad bflad mentioned this pull request Oct 30, 2018
Closed
@Hinidu
Set ForceNew for s3_backup_mode in aws_kinesis_firehose_delivery_stream
e04a2b4 
Fixes hashicorp#1369. Only for Elasticsearch target, because S3, Redshift and
Splunk APIs support changes of this parameter.
@Hinidu
Copy link
Contributor Author

Hinidu commented Oct 31, 2018

Hi @bflad! Thank you for review, I've made requested changes.

@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 31, 2018
bflad
bflad approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Hinidu! 🚀

@bflad bflad merged commit e524a9d into hashicorp:master Oct 31, 2018
@bflad bflad added this to the v1.42.0 milestone Oct 31, 2018
bflad added a commit that referenced this pull request Oct 31, 2018
@bflad
Update CHANGELOG for #6305
51e9e2a
@Hinidu
Copy link
Contributor Author

Hinidu commented Oct 31, 2018

Thanks!

@Hinidu Hinidu deleted the patch-1 branch October 31, 2018 10:40
@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/firehose Issues and PRs that pertain to the firehose service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.

aws_kinesis_firehose_delivery_stream does not manage s3_backup_mode
2 participants
@Hinidu @bflad