resource/aws_ecs_service: Continue supporting replica deployment_minimum_healthy_percent = 0 and deployment_maximum_percent = 100

[bflad]

This PR reverts some unexpected behaviors introduced by #6150 -- the defaults are safe to re-add as they match the API and previous resource schema.

Fixes #6315

Changes proposed in this pull request:

• Cleanup handling of replica versus daemon in Create/Update
• Add acceptance test for replica strategy with deployment minimum 0 and maximum 100
• Switch TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum to resource.ParallelTest() to match other tests

Previously:

--- FAIL: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (8.16s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_ecs_service.test: 1 error occurred:
        	* aws_ecs_service.test: InvalidParameterException: Both maximumPercent and minimumHealthyPercent cannot be 100 as this will block deployments.

Output from acceptance testing:

--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (248.39s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (30.56s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (15.64s)
--- PASS: TestAccAWSEcsService_disappears (20.72s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (14.37s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (30.45s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (30.86s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (30.93s)
--- PASS: TestAccAWSEcsService_basicImport (33.06s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (36.79s)
--- PASS: TestAccAWSEcsService_withARN (38.20s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (40.93s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (41.09s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (41.43s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (50.67s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (52.10s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (63.64s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (77.10s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (105.04s)
--- PASS: TestAccAWSEcsService_withIamRole (130.78s)
--- PASS: TestAccAWSEcsService_withLbChanges (218.96s)
--- PASS: TestAccAWSEcsService_withAlb (243.76s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (264.39s)

[mbfrahry]

LGTM

[bflad]

This has been released in version 1.43.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[aodeniyide]

@bflad fantastic! Thank you for the quick release.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!