Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): add py3.7 runtime support #6583

Merged
merged 1 commit into from
Nov 30, 2018
Merged

feat(lambda): add py3.7 runtime support #6583

merged 1 commit into from
Nov 30, 2018

Conversation

hanks
Copy link
Contributor

@hanks hanks commented Nov 26, 2018

Changes proposed in this pull request:

  • Add lambda function runtime 3.7 support

Output from acceptance testing:

2018/11/26 17:41:42 Start to execute command: [make testacc TESTARGS=-run=TestAccAWSLambdaFunction_runtimeValidation_python37]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLambdaFunction_runtimeValidation_python37 -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_python37
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_python37
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_python37
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (50.83s)
PASS

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 26, 2018
@hanks hanks changed the title feat(labmda): add py3.7 runtime support feat(lambda): add py3.7 runtime support Nov 26, 2018
@hanks hanks force-pushed the feat/add-lambda-py37-runtime-support branch from 6631b7c to a80ab70 Compare November 26, 2018 08:46
@hanks hanks mentioned this pull request Nov 29, 2018
Closed
@balassit
Copy link

Fixes #6620

@bflad bflad added this to the v1.51.0 milestone Nov 30, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 30, 2018
bflad
bflad approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hanks! 🚀

--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (22.49s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile_VPC (30.87s)
--- PASS: TestAccAWSLambdaFunction_basic (31.46s)
--- PASS: TestAccAWSLambdaFunction_importS3 (32.15s)
--- PASS: TestAccAWSLambdaFunction_versioned (34.61s)
--- PASS: TestAccAWSLambdaFunction_VPC (34.98s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (23.76s)
--- PASS: TestAccAWSLambdaFunction_importLocalFile (46.22s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (1.47s)
--- PASS: TestAccAWSLambdaFunction_s3 (20.20s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (53.86s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (56.52s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (30.11s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (29.06s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (64.43s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (67.96s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (34.06s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (37.81s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (71.40s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (73.97s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (75.85s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (28.33s)
--- PASS: TestAccAWSLambdaFunction_concurrency (77.67s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (81.94s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (83.55s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (33.10s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (86.51s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (31.53s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (26.37s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (92.08s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_nodeJs43 (49.51s)
--- PASS: TestAccAWSLambdaFunction_tags (43.05s)
--- PASS: TestAccAWSLambdaFunction_envVariables (103.46s)

@bflad bflad merged commit f3f4f65 into hashicorp:master Nov 30, 2018
@bflad bflad mentioned this pull request Nov 30, 2018
Closed
bflad added a commit that referenced this pull request Nov 30, 2018
@bflad
Update CHANGELOG for #6583
7774a84
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.51.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hanks @balassit @bflad