resource/aws_elasticache_parameter_group: Handle API reset issues with reserved-memory parameter #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues with reserved-memory parameter where possible
The Elasticache API is currently always returning an `InternalFailure` when attempting to reset the `reserved-memory` parameter. The resource previously provided an uphelpful timeout error with no way to workaround the behavior to properly update `reserved-memory` to a new value or switch to the `reserved-memory-percentage` parameter.
The resource now employs some handling to skip the `reserved-memory` reset, but only after its attempted before in case the Elasticache API is fixed in the future.
Changes:
* resource/aws_elasticache_parameter_group: Code and acceptance test workarounds for `reserved-memory` parameter always returning an error during update
* tests/resource/aws_elasticache_parameter_group: Switch from bespoke import test to always testing import
* tests/resource/aws_elasticache_parameter_group: Other minor refactoring to clean acceptance testing
Previously failing acceptance testing:
```
--- FAIL: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter (76.81s)
testing.go:538: Step 1 error: Error applying: 1 error occurred:
* aws_elasticache_parameter_group.bar: 1 error occurred:
* aws_elasticache_parameter_group.bar: Error resetting Cache Parameter Group: timeout while waiting for state to become 'success' (timeout: 30s)
--- FAIL: TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter (76.81s)
testing.go:538: Step 1 error: Error applying: 1 error occurred:
* aws_elasticache_parameter_group.bar: 1 error occurred:
* aws_elasticache_parameter_group.bar: Error resetting Cache Parameter Group: timeout while waiting for state to become 'success' (timeout: 30s)
--- FAIL: TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter (77.01s)
testing.go:538: Step 1 error: Error applying: 1 error occurred:
* aws_elasticache_parameter_group.bar: 1 error occurred:
* aws_elasticache_parameter_group.bar: Error resetting Cache Parameter Group: timeout while waiting for state to become 'success' (timeout: 30s)
```
Output from acceptance testing:
```
--- PASS: TestAccAWSElasticacheParameterGroup_basic (19.94s)
--- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (23.09s)
--- PASS: TestAccAWSElasticacheParameterGroup_Description (33.43s)
--- PASS: TestAccAWSElasticacheParameterGroup_addParameter (34.66s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeAllParameters (43.51s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter (43.57s)
--- PASS: TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter (86.12s)
--- PASS: TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter (95.82s)
```
bflad
added
bug
ghost
added
size/XL
mbfrahry
approved these changes
Dec 7, 2018
| } | ||
| } | ||
|
|
||
| if !tryReservedMemoryPercentageWorkaround { |
There was a problem hiding this comment.
I think we can remove this bit. I only see it becoming false on line 230 and we break there.
There was a problem hiding this comment.
That break is for the inner for loop. We need this boolean to determine the rest of this flow.
|
|
||
| // The reserved-memory-percentage parameter does not exist in redis2.6 and redis2.8 | ||
| family := d.Get("family").(string) | ||
| if family == "redis2.6" || family == "redis2.8" { |
There was a problem hiding this comment.
We should add a log here or I'm even tempted to error out if this value has changed while using this family
Suggested change
| if family == "redis2.6" || family == "redis2.8" { | |
| log.Printf("[WARN] unable to update `reserved-memory-percentage` while family is %q: %s", family, err) | |
There was a problem hiding this comment.
I'll add a warning log in there 👍
…d-memory parameter reset with redis2.6 and redis2.8
bflad
deleted the
b-aws_elasticache_parameter_group-reserved-memory-reset
branch
bflad
added a commit
that referenced
this pull request
Dec 7, 2018
|
This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Elasticache API is currently always returning an
InternalFailureerror when attempting to reset thereserved-memoryparameter. The Terraform resource previously provided an unhelpful timeout error with no way to workaround the behavior to properly updatereserved-memoryto a new value or switch to thereserved-memory-percentageparameter.The resource now employs some handling to skip the problematic
reserved-memoryreset, but only after its attempted before, in case the Elasticache API is fixed in the future.Changes:
reserved-memoryparameter always returning an error during updatePreviously failing acceptance testing:
Output from acceptance testing: