Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_batch_compute_environment: Remove deprecated ecc_cluster_arn attribute #7708

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 25, 2019

Closes #7684

Output from acceptance testing:

--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (19.65s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (20.93s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (32.65s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (41.09s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (43.16s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (47.57s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (49.41s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (62.80s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (65.42s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (80.69s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (87.94s)

…_arn attribute

Reference: #7684

Output from acceptance testing:

```
--- PASS: TestAccAWSBatchComputeEnvironment_createSpotWithoutBidPercentage (19.65s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithoutComputeResources (20.93s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanagedWithComputeResources (32.65s)
--- PASS: TestAccAWSBatchComputeEnvironment_createUnmanaged (41.09s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2 (43.16s)
--- PASS: TestAccAWSBatchComputeEnvironment_createEc2WithTags (47.57s)
--- PASS: TestAccAWSBatchComputeEnvironment_createSpot (49.41s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateMaxvCpus (62.80s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateState (65.42s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateComputeEnvironmentName (80.69s)
--- PASS: TestAccAWSBatchComputeEnvironment_updateInstanceType (87.94s)
```
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign. service/batch Issues and PRs that pertain to the batch service. labels Feb 25, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 25, 2019
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Feb 25, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit d7c5517 into master Feb 26, 2019
@bflad bflad deleted the td-aws_batch_compute_environment-remove-deprecated branch February 26, 2019 01:06
bflad added a commit that referenced this pull request Feb 26, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Version 2 Release] resource/aws_batch_compute_environment: Remove deprecated ecc_cluster_arn attribute
2 participants