Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ssm_patch_baseline: Support resource import #7838

Merged
merged 1 commit into from
Mar 14, 2019
Merged

resource/aws_ssm_patch_baseline: Support resource import #7838

merged 1 commit into from
Mar 14, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 6, 2019

Closes #7816

Also fixes operating system acceptance test name to follow current project consistency with a separating underscore.

Output from acceptance testing:

--- PASS: TestAccAWSSSMPatchBaseline_disappears (9.14s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (18.84s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (18.98s)

@bflad
resource/aws_ssm_patch_baseline: Support resource import
c3d363d 
Reference: #7816

Also fixes operating system acceptance test name to follow current project consistency with a separating underscore.

Output from acceptance testing:

```
--- PASS: TestAccAWSSSMPatchBaseline_disappears (9.14s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (18.84s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (18.98s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. labels Mar 6, 2019
@bflad bflad requested a review from a team March 6, 2019 18:49
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 6, 2019
nywilken
nywilken approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad modified the milestones: v2.1.0, v2.3.0, v2.2.0 Mar 8, 2019
@bflad bflad merged commit 5928177 into master Mar 14, 2019
@bflad bflad deleted the f-aws_ssm_patch_baseline-import branch March 14, 2019 16:55
bflad added a commit that referenced this pull request Mar 14, 2019
@bflad
Update CHANGELOG for #7838
18f00b4
@bflad
Copy link
Contributor Author

bflad commented Mar 15, 2019

This has been released in version 2.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Allow import aws_ssm_patch_baseline
2 participants
@bflad @nywilken