Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arn of the glue crawler #7948

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Add arn of the glue crawler #7948

merged 3 commits into from
Mar 15, 2019

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7934

Changes proposed in this pull request:

  • Add arn attribute for the glue crawler resource.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCrawler_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSGlueCrawler_ -timeout 120m
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_S3Target
=== PAUSE TestAccAWSGlueCrawler_S3Target
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
=== PAUSE TestAccAWSGlueCrawler_S3Target_Exclusions
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
=== PAUSE TestAccAWSGlueCrawler_S3Target_Multiple
=== RUN   TestAccAWSGlueCrawler_recreates
=== PAUSE TestAccAWSGlueCrawler_recreates
=== RUN   TestAccAWSGlueCrawler_Classifiers
=== PAUSE TestAccAWSGlueCrawler_Classifiers
=== RUN   TestAccAWSGlueCrawler_Configuration
=== PAUSE TestAccAWSGlueCrawler_Configuration
=== RUN   TestAccAWSGlueCrawler_Description
=== PAUSE TestAccAWSGlueCrawler_Description
=== RUN   TestAccAWSGlueCrawler_Role_ARN_NoPath
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_NoPath
=== RUN   TestAccAWSGlueCrawler_Role_ARN_Path
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_Path
=== RUN   TestAccAWSGlueCrawler_Role_Name_Path
=== PAUSE TestAccAWSGlueCrawler_Role_Name_Path
=== RUN   TestAccAWSGlueCrawler_Schedule
=== PAUSE TestAccAWSGlueCrawler_Schedule
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
=== PAUSE TestAccAWSGlueCrawler_SchemaChangePolicy
=== RUN   TestAccAWSGlueCrawler_TablePrefix
=== PAUSE TestAccAWSGlueCrawler_TablePrefix
=== RUN   TestAccAWSGlueCrawler_SecurityConfiguration
=== PAUSE TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_Schedule
=== CONT  TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget
=== CONT  TestAccAWSGlueCrawler_Role_Name_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_NoPath
=== CONT  TestAccAWSGlueCrawler_Description
=== CONT  TestAccAWSGlueCrawler_Configuration
=== CONT  TestAccAWSGlueCrawler_Classifiers
=== CONT  TestAccAWSGlueCrawler_recreates
=== CONT  TestAccAWSGlueCrawler_S3Target_Multiple
=== CONT  TestAccAWSGlueCrawler_S3Target_Exclusions
=== CONT  TestAccAWSGlueCrawler_S3Target
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== CONT  TestAccAWSGlueCrawler_TablePrefix
=== CONT  TestAccAWSGlueCrawler_JdbcTarget
=== CONT  TestAccAWSGlueCrawler_SchemaChangePolicy
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (54.94s)
--- PASS: TestAccAWSGlueCrawler_recreates (57.04s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (58.20s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (66.06s)
--- PASS: TestAccAWSGlueCrawler_Configuration (76.62s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (77.19s)
--- PASS: TestAccAWSGlueCrawler_Description (81.93s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (82.54s)
--- PASS: TestAccAWSGlueCrawler_S3Target (85.16s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (85.33s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (91.27s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (93.95s)
--- PASS: TestAccAWSGlueCrawler_Schedule (94.12s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (94.81s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (104.17s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (108.94s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (113.93s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (116.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	116.966s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 15, 2019
bflad
bflad reviewed Mar 15, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, @kterada0509, can you please also add this resource to the list of skip_requesting_account_id resources in website/docs/index.html.markdown? Much appreciated!

aws/resource_aws_glue_crawler.go Outdated
@@ -459,6 +463,14 @@ func resourceAwsGlueCrawlerRead(d *schema.ResourceData, meta interface{}) error
return nil
}

arn := arn.ARN{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be careful to not shadow the import name by calling this crawlerARN := or something. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 15, 2019
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Mar 15, 2019
@teraken0509
Copy link
Contributor Author

This is looking good, @kterada0509, can you please also add this resource to the list of skip_requesting_account_id resources in website/docs/index.html.markdown? Much appreciated!

@bflad Fixed it.

@bflad bflad added this to the v2.2.0 milestone Mar 15, 2019
bflad
bflad approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (30.35s)
--- PASS: TestAccAWSGlueCrawler_recreates (37.49s)
--- PASS: TestAccAWSGlueCrawler_Configuration (47.17s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (52.23s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (56.84s)
--- PASS: TestAccAWSGlueCrawler_Schedule (63.51s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (65.80s)
--- PASS: TestAccAWSGlueCrawler_Description (68.51s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (69.05s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (74.99s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (77.72s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (80.57s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (81.44s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (83.13s)
--- PASS: TestAccAWSGlueCrawler_S3Target (83.16s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (84.89s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (99.76s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (140.95s)

@bflad bflad merged commit 1cdf0e0 into hashicorp:master Mar 15, 2019
bflad added a commit that referenced this pull request Mar 15, 2019
@bflad
Update CHANGELOG for #7948
731ab88
@bflad
Copy link
Contributor

bflad commented Mar 15, 2019

This has been released in version 2.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-arn-for-aws_glue_crawler-resource branch March 5, 2020 14:00
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Provide ARN attribute on Glue Crawler
2 participants
@teraken0509 @bflad