Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support AppSync Function Resource and pipeline configuration for resolver #8502

Conversation

teraken0509
Copy link
Contributor

@teraken0509 teraken0509 commented May 2, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8127

Release note for CHANGELOG:

- New Resource: aws_appsync_function (#8127)
- resource/aws_appsync_resolver: Add `pipeline_config` attribute (#8127)

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsAppsyncFunction_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsAppsyncFunction_ -timeout 120m
=== RUN   TestAccAwsAppsyncFunction_basic
=== PAUSE TestAccAwsAppsyncFunction_basic
=== RUN   TestAccAwsAppsyncFunction_description
=== PAUSE TestAccAwsAppsyncFunction_description
=== RUN   TestAccAwsAppsyncFunction_responseMappingTemplate
=== PAUSE TestAccAwsAppsyncFunction_responseMappingTemplate
=== RUN   TestAccAwsAppsyncFunction_disappears
=== PAUSE TestAccAwsAppsyncFunction_disappears
=== CONT  TestAccAwsAppsyncFunction_basic
=== CONT  TestAccAwsAppsyncFunction_disappears
=== CONT  TestAccAwsAppsyncFunction_responseMappingTemplate
=== CONT  TestAccAwsAppsyncFunction_description
--- PASS: TestAccAwsAppsyncFunction_disappears (73.59s)
--- PASS: TestAccAwsAppsyncFunction_description (95.39s)
--- PASS: TestAccAwsAppsyncFunction_basic (96.09s)
--- PASS: TestAccAwsAppsyncFunction_responseMappingTemplate (139.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	139.963s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsAppsyncResolver_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsAppsyncResolver_ -timeout 120m
=== RUN   TestAccAwsAppsyncResolver_basic
=== PAUSE TestAccAwsAppsyncResolver_basic
=== RUN   TestAccAwsAppsyncResolver_disappears
=== PAUSE TestAccAwsAppsyncResolver_disappears
=== RUN   TestAccAwsAppsyncResolver_DataSource
=== PAUSE TestAccAwsAppsyncResolver_DataSource
=== RUN   TestAccAwsAppsyncResolver_RequestTemplate
=== PAUSE TestAccAwsAppsyncResolver_RequestTemplate
=== RUN   TestAccAwsAppsyncResolver_ResponseTemplate
=== PAUSE TestAccAwsAppsyncResolver_ResponseTemplate
=== RUN   TestAccAwsAppsyncResolver_multipleResolvers
=== PAUSE TestAccAwsAppsyncResolver_multipleResolvers
=== RUN   TestAccAwsAppsyncResolver_PipelineConfig
=== PAUSE TestAccAwsAppsyncResolver_PipelineConfig
=== CONT  TestAccAwsAppsyncResolver_basic
=== CONT  TestAccAwsAppsyncResolver_ResponseTemplate
=== CONT  TestAccAwsAppsyncResolver_PipelineConfig
=== CONT  TestAccAwsAppsyncResolver_multipleResolvers
=== CONT  TestAccAwsAppsyncResolver_RequestTemplate
=== CONT  TestAccAwsAppsyncResolver_disappears
=== CONT  TestAccAwsAppsyncResolver_DataSource
--- PASS: TestAccAwsAppsyncResolver_disappears (34.36s)
--- PASS: TestAccAwsAppsyncResolver_PipelineConfig (37.39s)
--- PASS: TestAccAwsAppsyncResolver_basic (40.98s)
--- PASS: TestAccAwsAppsyncResolver_RequestTemplate (52.62s)
--- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (58.14s)
--- PASS: TestAccAwsAppsyncResolver_DataSource (59.19s)
--- PASS: TestAccAwsAppsyncResolver_multipleResolvers (62.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	62.168s

@ghost ghost added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels May 2, 2019
@teraken0509 teraken0509 force-pushed the feature/add-support-aws_appsync_function-resource branch from 02c0003 to bb4fb2a Compare May 7, 2019 15:41
@teraken0509 teraken0509 marked this pull request as ready for review May 7, 2019 15:42
@ouadie-lahdioui
Copy link

+1

3 similar comments
@witooh
Copy link

witooh commented Jun 11, 2019

👍

@zepia-x37
Copy link

👍

@Amornthep
Copy link

👍

@laurentlouk
Copy link

Why this takes so long ? x)

@rimutaka
Copy link
Contributor

I successfully used this PR in a custom build with no apparent issues.

@bflad bflad self-assigned this Jun 27, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAwsAppsyncResolver_basic (13.76s)
--- PASS: TestAccAwsAppsyncResolver_multipleResolvers (20.92s)
--- PASS: TestAccAwsAppsyncResolver_RequestTemplate (21.01s)
--- PASS: TestAccAwsAppsyncResolver_DataSource (25.54s)
--- PASS: TestAccAwsAppsyncResolver_disappears (26.49s)
--- PASS: TestAccAwsAppsyncResolver_PipelineConfig (27.00s)
--- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (33.15s)
--- PASS: TestAccAwsAppsyncFunction_disappears (117.42s)
--- PASS: TestAccAwsAppsyncFunction_responseMappingTemplate (118.06s)
--- PASS: TestAccAwsAppsyncFunction_basic (123.75s)
--- PASS: TestAccAwsAppsyncFunction_description (124.64s)

"name": {
Type: schema.TypeString,
Required: true,
ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: In the future this should be simplified to use validation.StringMatch()

_, err = conn.GetFunction(input)
if err != nil {
if isAWSErr(err, appsync.ErrCodeNotFoundException, "") {
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this in the future:

Suggested change
return nil
continue

@bflad bflad added this to the v2.17.0 milestone Jun 27, 2019
@bflad bflad merged commit 3d8a1ae into hashicorp:master Jun 27, 2019
bflad added a commit that referenced this pull request Jun 27, 2019
@bflad
Copy link
Contributor

bflad commented Jun 28, 2019

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
@teraken0509 teraken0509 deleted the feature/add-support-aws_appsync_function-resource branch March 5, 2020 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appsync Issues and PRs that pertain to the appsync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AppSync pipeline resolvers
8 participants