-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support AppSync Function Resource and pipeline configuration for resolver #8502
Add support AppSync Function Resource and pipeline configuration for resolver #8502
Conversation
02c0003
to
bb4fb2a
Compare
+1 |
3 similar comments
👍 |
👍 |
👍 |
Why this takes so long ? x) |
I successfully used this PR in a custom build with no apparent issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kterada0509 🚀
--- PASS: TestAccAwsAppsyncResolver_basic (13.76s)
--- PASS: TestAccAwsAppsyncResolver_multipleResolvers (20.92s)
--- PASS: TestAccAwsAppsyncResolver_RequestTemplate (21.01s)
--- PASS: TestAccAwsAppsyncResolver_DataSource (25.54s)
--- PASS: TestAccAwsAppsyncResolver_disappears (26.49s)
--- PASS: TestAccAwsAppsyncResolver_PipelineConfig (27.00s)
--- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (33.15s)
--- PASS: TestAccAwsAppsyncFunction_disappears (117.42s)
--- PASS: TestAccAwsAppsyncFunction_responseMappingTemplate (118.06s)
--- PASS: TestAccAwsAppsyncFunction_basic (123.75s)
--- PASS: TestAccAwsAppsyncFunction_description (124.64s)
"name": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: In the future this should be simplified to use validation.StringMatch()
_, err = conn.GetFunction(input) | ||
if err != nil { | ||
if isAWSErr(err, appsync.ErrCodeNotFoundException, "") { | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix this in the future:
return nil | |
continue |
This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Fixes #8127
Release note for CHANGELOG:
Output from acceptance testing: