Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry timeout error for acmpca cert authority #8856

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference #7873

Release note for CHANGELOG:

Bug Fixes:
* resource/aws_acmpca_certificate_authority: Add retry after timeout
when creating CA

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAwsAcmpcaCertificateAuthority"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsAcmpcaCertificateAuthority -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsAcmpcaCertificateAuthority_Basic
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_Basic
=== RUN   TestAccAwsAcmpcaCertificateAuthority_Enabled
--- SKIP: TestAccAwsAcmpcaCertificateAuthority_Enabled (0.00s)
    resource_aws_acmpca_certificate_authority_test.go:112: We need to fully sign the certificate authority CSR from another CA in order to test this functionality, which requires another resource
=== RUN   TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname
=== RUN   TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled
=== RUN   TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays
=== RUN   TestAccAwsAcmpcaCertificateAuthority_Tags
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_Tags
=== CONT  TestAccAwsAcmpcaCertificateAuthority_Basic
=== CONT  TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays
=== CONT  TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname
=== CONT  TestAccAwsAcmpcaCertificateAuthority_Tags
=== CONT  TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Basic (20.09s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Tags (50.81s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_ExpirationInDays (64.02s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_Enabled (81.72s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_RevocationConfiguration_CrlConfiguration_CustomCname (109.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       110.806s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/acmpca Issues and PRs that pertain to the acmpca service. labels Jun 4, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jun 4, 2019
@bflad bflad added this to the v2.14.0 milestone Jun 4, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bflad bflad assigned bflad and ryndaniels and unassigned bflad Jun 4, 2019
@ryndaniels ryndaniels merged commit d8bc1de into master Jun 5, 2019
bflad added a commit that referenced this pull request Jun 6, 2019
@bflad
Copy link
Contributor

bflad commented Jun 7, 2019

This has been released in version 2.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/acmpca Issues and PRs that pertain to the acmpca service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants