Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_customer_gateway #8977

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Conversation

ripta
Copy link
Contributor

@ripta ripta commented Jun 12, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #5007

Release note for CHANGELOG:

**New Data Source:** `aws_customer_gateway`

Output from acceptance testing:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCustomerGatewayDataSource*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCustomerGatewayDataSource* -timeout 120m
=== RUN   TestAccAWSCustomerGatewayDataSource_Filter
=== PAUSE TestAccAWSCustomerGatewayDataSource_Filter
=== RUN   TestAccAWSCustomerGatewayDataSource_ID
=== PAUSE TestAccAWSCustomerGatewayDataSource_ID
=== CONT  TestAccAWSCustomerGatewayDataSource_Filter
=== CONT  TestAccAWSCustomerGatewayDataSource_ID
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (19.92s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (20.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.364s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 12, 2019
@bflad bflad added the new-data-source Introduces a new data source. label Jun 13, 2019
@bflad bflad added this to the v2.15.0 milestone Jun 13, 2019
@bflad bflad self-assigned this Jun 13, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ripta, thanks! 🚀

--- PASS: TestAccAWSCustomerGatewayDataSource_ID (23.08s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (23.56s)

@bflad bflad merged commit 8926063 into hashicorp:master Jun 13, 2019
bflad added a commit that referenced this pull request Jun 13, 2019
@ripta ripta deleted the data-cgw branch June 13, 2019 17:57
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data source for aws_customer_gateway
2 participants