Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/resource_aws_dms_endpoint: add db2 support #9097

Merged
merged 1 commit into from
Jun 25, 2019
Merged

aws/resource_aws_dms_endpoint: add db2 support #9097

merged 1 commit into from
Jun 25, 2019

Conversation

kireledan
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7312

Release note for CHANGELOG:

* Added support for db2 engine in `aws_dms_endpoint`

Output from acceptance testing:

kireledan@Erik-PC:~/Documents/gitstuff/terraform-provider-aws$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsDmsEndpointDb2'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAwsDmsEndpointDb2 -timeout 120m
=== RUN   TestAccAwsDmsEndpointDb2
=== PAUSE TestAccAwsDmsEndpointDb2
=== CONT  TestAccAwsDmsEndpointDb2
--- PASS: TestAccAwsDmsEndpointDb2 (30.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.662s


...

@kireledan
aws/resource_aws_dms_endpoint: add db2 support
6c88ac4 
This commit adds db2 engine support for the resource 'aws_dms_endpoint'.

The documentation has been updated to reflect this change and an acceptance
test has been added to show the working functionality of this change.
@kireledan kireledan requested a review from a team June 23, 2019 00:56
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/databasemigrationservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 23, 2019
@kireledan kireledan mentioned this pull request Jun 23, 2019
Closed
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 25, 2019
@bflad bflad self-assigned this Jun 25, 2019
@bflad bflad added this to the v2.17.0 milestone Jun 25, 2019
bflad
bflad approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks, @kireledan 🚀

--- PASS: TestAccAwsDmsEndpointBasic (13.60s)
--- PASS: TestAccAwsDmsEndpointDocDB (14.08s)
--- PASS: TestAccAwsDmsEndpointDb2 (14.33s)
--- PASS: TestAccAwsDmsEndpointMongoDb (16.06s)
--- PASS: TestAccAwsDmsEndpointDynamoDb (26.00s)
--- PASS: TestAccAwsDmsEndpointS3 (34.04s)

@bflad bflad merged commit d6e3056 into hashicorp:master Jun 25, 2019
bflad added a commit that referenced this pull request Jun 25, 2019
@bflad
Update CHANGELOG for #9097
dc417b9
@kireledan kireledan deleted the kireledan/db2-dms branch June 25, 2019 03:05
@bflad
Copy link
Contributor

bflad commented Jun 28, 2019

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.17.0
Development

Successfully merging this pull request may close these issues.

Add DB2 to aws_dms_endpoint engine_name
2 participants
@kireledan @bflad