Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS App Mesh service discovery using AWS Cloud Map #9271

Merged
merged 2 commits into from
Jul 9, 2019
Merged

AWS App Mesh service discovery using AWS Cloud Map #9271

merged 2 commits into from
Jul 9, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8997.

Release note for CHANGELOG:

ENHANCEMENTS:

* resource/aws_appmesh_virtual_node: Add `aws_cloud_map` configuration block

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/tags
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
--- PASS: TestAccAWSAppmesh (458.26s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (458.26s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (152.12s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (66.84s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (76.73s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tags (123.31s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (39.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	458.328s

@ewbankkit ewbankkit requested a review from a team July 8, 2019 20:25
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 8, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 9, 2019
@bflad bflad added this to the v2.19.0 milestone Jul 9, 2019
bflad
bflad approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ewbankkit 🚀

--- PASS: TestAccAWSAppmesh (304.86s)

@bflad bflad merged commit 539f7a8 into hashicorp:master Jul 9, 2019
bflad added a commit that referenced this pull request Jul 9, 2019
@bflad
Update CHANGELOG for #9271
e14e760
@ewbankkit ewbankkit deleted the issue-8997 branch July 9, 2019 16:54
@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.

AWS App Mesh service discovery using AWS Cloud Map
2 participants
@ewbankkit @bflad